Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Transfer context ownership #945

Merged
merged 3 commits into from
Apr 3, 2024
Merged

feat: Transfer context ownership #945

merged 3 commits into from
Apr 3, 2024

Conversation

enjeck
Copy link
Contributor

@enjeck enjeck commented Mar 20, 2024

Closes #898

@enjeck enjeck marked this pull request as ready for review March 26, 2024 11:36
@enjeck enjeck requested review from juliusknorr and elzody March 26, 2024 12:24
@enjeck enjeck requested a review from blizzz as a code owner March 27, 2024 14:55
Base automatically changed from feat/contexts to main March 27, 2024 16:35
@juliusknorr juliusknorr added enhancement New feature or request 3. to review Waiting for reviews labels Mar 27, 2024
@juliusknorr
Copy link
Member

Rebased after the merge of the context branch to main

enjeck and others added 3 commits April 2, 2024 13:12
@enjeck
feat: transfer context ownership
c6164bb 
Signed-off-by: Cleopatra Enjeck M <[email protected]>
@blizzz @enjeck
enh(Contexts): extend permission check
3cf2ca9 
- checkPermission(ById) takes inherited permissions via Context into account
- adds query to fetch all contexts containing a certain node
- adds permission constants to Application

Signed-off-by: Arthur Schiwon <[email protected]>
@enjeck
fix: load tables/views from transferred context
72afabb 
Signed-off-by: Cleopatra Enjeck M <[email protected]>
@blizzz
Copy link
Member

blizzz commented Apr 3, 2024

@elzody @juliushaertl could we have a review on the frond-end bits?

The backend part got its approval in #947 and was merged into this branch.

elzody
elzody approved these changes Apr 3, 2024
View reviewed changes
Copy link
Contributor

@elzody elzody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Transferring seems to work as expected for me

@blizzz blizzz merged commit b0a793e into main Apr 3, 2024
57 checks passed
@blizzz blizzz deleted the feat/898 branch April 3, 2024 17:39
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 4, 2024

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elzody elzody elzody approved these changes

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

@blizzz blizzz Awaiting requested review from blizzz blizzz is a code owner

Assignees
No one assigned
Labels
3. to review Waiting for reviews enhancement New feature or request feedback-requested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Applications: Transfer ownership
4 participants
@enjeck @juliusknorr @blizzz @elzody