fix: increase smartpicker select height

[enjeck]

Addresses: #751

[enjeck]

Before:

After:

[datenangebot]

@enjeck I would recommend to adjust the padding for a more calm appearance.

[enjeck]

Here's what it looks like now:

[datenangebot]

Yeah, that looks so much better. 😁
If you want to do it perfect, you should use the default value for spacings: https://github.com/nextcloud/server/blob/89ee85938e2c66e8d1c20f57fa754b72509e524f/apps/theming/css/default.css#L57

Something like
padding: calc(var(--default-grid-baseline) * 1)

[enjeck]

Yeah, that looks so much better. 😁 If you want to do it perfect, you should use the default value for spacings: https://github.com/nextcloud/server/blob/89ee85938e2c66e8d1c20f57fa754b72509e524f/apps/theming/css/default.css#L57

Something like padding: calc(var(--default-grid-baseline) * 1)

There are other conflicting styles here, so modifying the padding here doesn't fix this easily

[datenangebot]

This is what I found -> and suggest to chance

old	new

@enjeck What do you think? Can you review please.

[enjeck]

Looks good. But wondering if we want to only apply the padding after selection (or if this is even possible). Right now, the empty search bar looks massive, and maybe this is awkward?:

[datenangebot]

Looks good. But wondering if we want to only apply the padding after selection (or if this is even possible). Right now, the empty search bar looks massive, and maybe this is awkward?:

Well, yes and no. I would say you're right, looks to massive. But if we make it smaller, it will resize if we choose one option, might look a bit like jumping elements? 🙄

[enjeck]

@datenangebot Good point, thanks.

[github-actions]

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!