Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(DB): fetch pageId as int #1083

Merged
merged 1 commit into from
May 13, 2024
Merged

fix(DB): fetch pageId as int #1083

merged 1 commit into from
May 13, 2024

Conversation

blizzz
Copy link
Member

@blizzz blizzz commented May 10, 2024

fixes #1081

Signed-off-by: Arthur Schiwon <[email protected]>
@blizzz blizzz added bug Something isn't working 3. to review Waiting for reviews labels May 10, 2024
@blizzz blizzz requested review from juliusknorr and enjeck May 10, 2024 14:18
Copy link
Member

@juliusknorr juliusknorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I always wonder if the query builder could not cast those automatically, but I guess it cause we don't have type information on the php side for the columns and sqlite considering everything as a string 🙈

@enjeck enjeck merged commit f616310 into main May 13, 2024
58 checks passed
@enjeck enjeck deleted the fix/1081/serve-pageid-as-int branch May 13, 2024 07:56
@blizzz
Copy link
Member Author

blizzz commented May 13, 2024

/backport to stable0.7

@backportbot backportbot bot added the backport-request Pending backport by the backport-bot label May 13, 2024
@backportbot backportbot bot removed the backport-request Pending backport by the backport-bot label May 13, 2024
@blizzz
Copy link
Member Author

blizzz commented May 13, 2024

I always wonder if the query builder could not cast those automatically, but I guess it cause we don't have type information on the php side for the columns and sqlite considering everything as a string 🙈

The QBMapper usually would do that, but is not used here. A pitfall to be aware about. Having this automatic with the DB abstraction (based on migration?) would be fancy indeed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Delete application does not work
3 participants