Add an icon to the call button to draw more attention #2985
Conversation
Signed-off-by: Joas Schilling <[email protected]>
nickvergessen
added
2. developing
enhancement
papercut
feature: frontend 🖌️
| @@ -80,6 +80,15 @@ | |||
| @include icon-color('video', 'actions', 'E9322D', 1, true); | |||
| } | |||
|
|
|||
| .icon-start-call, | |||
| .icon-incoming-call { | |||
| @include icon-color('video', 'actions', $color-primary-text, 1, true); | |||
There was a problem hiding this comment.
Broken on dark mode due to nextcloud/server#19565
|
/backport to stable18 |
|
Please review @ma12-co |
|
backport to stable18 in #3008 |
|
There are two minor style issues (loading icon image instead of pure CSS and default cursor on icon instead of pointer) that come from the server and will be fixed there (nextcloud/server#19671 and nextcloud/server#19672). I guess those fixes will not be backported to stable18 in server, should they be fixed only for Talk 8 in #3008 (or a follow up)? |
If it is not important enough to backport it, then we don't backport it in talk either |
It is not the same; the fixes in the server are not actually "needed", because it can be solved without problems in the apps (for example, as it was done for the clipboard in Talk 7). But in Talk 8 the issue will be visible in the call button. But OK, no fix for Talk 8, less work ;-) |
Fix #2543