Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow moderators to force speaker/grid view for everyone #13655

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

DorraJaouad
Copy link
Contributor

@DorraJaouad DorraJaouad commented Oct 28, 2024

☑️ Resolves

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

🏚️ Before 🏡 After
Screenshot before Screenshot after

🚧 Tasks

  • Set the signaling emission
  • Apply the call view restriction
  • Separate component for call moderation (taking into consideration future options to be included)
  • Improve modal layout (kinda ugly rn)
  • Migrate the new component to composition API
  • Adjust the signaling attr to default to "none" instead of ""
  • disable view changing button for non-moderators

Missing functionalities to add

  • Late joiners should have the view enforced if it was emitted before joining
  • Hint for participants when the force view mode is on (?)
  • Select specific video/screenshare to force on
  • Show floating button to stop the force view mode on CallView when it is on (?)

🏁 Checklist

  • 🌏 Tested with different browsers / clients:
    • Chromium (Chrome / Edge / Opera / Brave)
    • Firefox
    • Safari
    • Talk Desktop
    • Not risky to browser differences / client
  • 🖌️ Design was reviewed, approved or inspired by the design team
  • ⛑️ Tests are included or not possible
  • 📗 User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/talk has been updated or is not required

Signed-off-by: DorraJaouad <[email protected]>
@DorraJaouad DorraJaouad self-assigned this Oct 28, 2024
@nickvergessen
Copy link
Member

Just mentioning as I don't see it in the check lists.
The moderator must also be able to force a specific video/screenshare to be looked at. Not only the general grid/speaker toggle.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Moderators must be able to force speaker/grid view for everyone
2 participants