Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(email): Recognize guests invited via email #13499

Merged
merged 14 commits into from
Oct 23, 2024
Merged

feat(email): Recognize guests invited via email #13499

merged 14 commits into from
Oct 23, 2024

Conversation

nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Oct 9, 2024 •
edited
Loading

☑️ Resolves

🛠️ API Checklist

🚧 Tasks

  • Add access token to email link
  • Should show that we identified the email in the "Guest name dialog"
  • Using the email as actor id might cause GDPR, need to hash at least?
    • Still need a reliable email address to attendee way
  • Don't abuse user_status line for sending the email to moderators in the participant list
  • Many places assume guests are actorType = Attendee::ACTOR_GUEST while it should be participantType = Participant::GUEST || participantType = Participant::GUEST_MODERATOR ?
    • Email users are not counted or listed in call summary
    • Auto complete search plugin and mentioning
    • ParserSystemMessage::isCurrentParticipantChangedUser
    • Parse SystemMessage when the guest is modified (promoted/demoted/poll/…)
    • System messages generated by the email-user can not find a display name and use wrong actor id
    • Reference provider
    • Cleaning up sessions by last ping?
    • Message::isReplyable
    • Notifier
    • Search result display name
    • Banning should disinvite
    • Check bots
    • Email guests should never expire?
    • ParticipantService::getGuestCount check usage whether email/display names should be expended instead of count the emails as well
    • Signaling participantsModified and roomInCallChanged excludes by actorType
    • …
  • ⚡ Test HPB
  • ☎️ Test SIP

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not possible
  • 📘 API documentation in docs/ has been updated or is not required
  • 🔖 Capability is added or not needed

@nickvergessen nickvergessen marked this pull request as draft October 9, 2024 04:38
@nickvergessen nickvergessen added this to the 🖤 Next Major (31) milestone Oct 9, 2024
@nickvergessen nickvergessen added 2. developing enhancement feature: api 🛠️ OCS API for conversations, chats and participants feature: meetings 📅 Covering the webinary usecase incl. Lobby feature: conversations 👥 labels Oct 9, 2024
@nickvergessen nickvergessen self-assigned this Oct 9, 2024
@nickvergessen nickvergessen force-pushed the feat/6098/recognize-email-invited-guests branch from c2c1274 to a673b3a Compare October 15, 2024 12:45
@nickvergessen nickvergessen mentioned this pull request Oct 17, 2024
Merged
4 tasks
@nickvergessen nickvergessen force-pushed the feat/6098/recognize-email-invited-guests branch 2 times, most recently from a81cdfb to ed01b27 Compare October 18, 2024 15:08
@nickvergessen nickvergessen mentioned this pull request Oct 18, 2024
Merged
1 task
@nickvergessen nickvergessen marked this pull request as ready for review October 18, 2024 21:57
@Antreesy
Copy link
Contributor

Antreesy commented Oct 21, 2024 •
edited
Loading

For quick test without receiving actual e-mail:
https://<NC_instance>/call/<token>?email=<email>&access=<access_token_from_DB>

For Julius docker setup: https://mail.local also works

Antreesy
Antreesy reviewed Oct 21, 2024
View reviewed changes
Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested with inviting, banning, chatting

lib/Controller/PageController.php Show resolved Hide resolved
lib/Controller/PageController.php Show resolved Hide resolved
@DorraJaouad
Copy link
Contributor

Tested ✅

@nickvergessen
fix(email): Treat email guests like normal guests in some cases
6af6d5c 
Signed-off-by: Joas Schilling <[email protected]>
@nickvergessen
fix(email): Allow mentioning email guests
63adde2 
Signed-off-by: Joas Schilling <[email protected]>
@nickvergessen
fix(email): Fix handling of email guests in system messages
3e0d4c0 
Signed-off-by: Joas Schilling <[email protected]>
@nickvergessen
feat(email): Handle mentioned email guests
3ba5adf 
Signed-off-by: Joas Schilling <[email protected]>
@nickvergessen
feat(emails): Allow banning email guests
de5200a 
Signed-off-by: Joas Schilling <[email protected]>
@nickvergessen
fix(emails): Expire the session but not the attendees for email guests
b9c3a2b 
Signed-off-by: Joas Schilling <[email protected]>
@nickvergessen
fix(calls): Count email guests as guests in the call summary
88e7cfc 
Signed-off-by: Joas Schilling <[email protected]>
@nickvergessen
docs(bots): Clarify the random guest actor id
b8c76b0 
Signed-off-by: Joas Schilling <[email protected]>
@nickvergessen
fix(emails): Use dedicated key in API response
4cb26cc 
Signed-off-by: Joas Schilling <[email protected]>
@nickvergessen
fix(emails): Fix integration tests assuming the email is the actorId
4874ab5 
Signed-off-by: Joas Schilling <[email protected]>
@nickvergessen
chore(openapi): Recompile openapi
13f8f71 
Signed-off-by: Joas Schilling <[email protected]>
@nickvergessen
fix(ban): Allow email guests to bypass bans on their IP
644c3fa 
Signed-off-by: Joas Schilling <[email protected]>
@nickvergessen nickvergessen force-pushed the feat/6098/recognize-email-invited-guests branch from 4e2476f to 644c3fa Compare October 23, 2024 04:24
@nickvergessen nickvergessen mentioned this pull request Oct 23, 2024
Draft
6 tasks
@nickvergessen nickvergessen merged commit fbdbd56 into main Oct 23, 2024
69 checks passed
@nickvergessen nickvergessen deleted the feat/6098/recognize-email-invited-guests branch October 23, 2024 12:02
@nickvergessen
Copy link
Member Author

/backport to stable30

@backportbot backportbot bot mentioned this pull request Oct 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Antreesy Antreesy Antreesy left review comments

@skalidindi53 skalidindi53 skalidindi53 approved these changes

@Ivansss Ivansss Awaiting requested review from Ivansss

Assignees

@nickvergessen nickvergessen

Labels
3. to review enhancement feature: api 🛠️ OCS API for conversations, chats and participants feature: conversations 👥 feature: meetings 📅 Covering the webinary usecase incl. Lobby
Projects
None yet
Milestone
🖤 Next Major (31)
Development

Successfully merging this pull request may close these issues.

recognice people invited by mail when they join the conversation
4 participants
@nickvergessen @Antreesy @DorraJaouad @skalidindi53