Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Reactions): show all names if they are at most 4 reactions #13116

Merged
merged 1 commit into from
Aug 23, 2024
Merged

fix(Reactions): show all names if they are at most 4 reactions #13116

merged 1 commit into from
Aug 23, 2024

Conversation

DorraJaouad
Copy link
Contributor

☑️ Resolves

  • Fix: instead of "A, B, C, and 1 other participant", it is now "A, B, C, and D" , +1 "A, B, C, and 2 other participants" ....

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

🏚️ Before 🏡 After
image image

🏁 Checklist

  • 🌏 Tested with different browsers / clients:
    • Chromium (Chrome / Edge / Opera / Brave)
    • Firefox
    • Safari
    • Talk Desktop
    • Not risky to browser differences / client
  • 🖌️ Design was reviewed, approved or inspired by the design team
  • ⛑️ Tests are included or not possible
  • 📗 User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/talk has been updated or is not required

@DorraJaouad DorraJaouad added this to the 💙 Next RC (30) milestone Aug 23, 2024
@DorraJaouad DorraJaouad requested a review from Antreesy August 23, 2024 10:55
@DorraJaouad DorraJaouad self-assigned this Aug 23, 2024
@DorraJaouad DorraJaouad force-pushed the fix/noid/reactions-summary branch from b4d043b to da5fdb5 Compare August 23, 2024 14:19
@DorraJaouad DorraJaouad enabled auto-merge August 23, 2024 14:53
@DorraJaouad DorraJaouad merged commit 498b56f into main Aug 23, 2024
46 checks passed
@DorraJaouad DorraJaouad deleted the fix/noid/reactions-summary branch August 23, 2024 14:59
@Antreesy
Copy link
Contributor

/backport to stable30

@backportbot backportbot bot mentioned this pull request Aug 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Antreesy Antreesy Antreesy left review comments

@ShGKme ShGKme ShGKme approved these changes

@nickvergessen nickvergessen nickvergessen approved these changes

Assignees

@DorraJaouad DorraJaouad

Labels
enhancement feature: chat 💬 Chat and system messages feature: frontend 🖌️ "Web UI" client feature: reactions 👍
Projects
None yet
Milestone
v21.0.0-beta.1
Development

Successfully merging this pull request may close these issues.
4 participants
@DorraJaouad @Antreesy @nickvergessen @ShGKme