Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(chat): Edit message mention support #11365

Merged
merged 2 commits into from
Jan 18, 2024
Merged

feat(chat): Edit message mention support #11365

merged 2 commits into from
Jan 18, 2024

Conversation

nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Jan 10, 2024 •
edited
Loading

☑️ Resolves

Ref #11206

🛠️ API Checklist

  • It is known that the indicator for unread mentions can not be removed/reverted in the left sidebar, due to complexity of the necessary database query we would need to run.

🚧 Tasks

  • Should diff mentions and add/remove notifications accordingly
  • Make sure people don't get 1 for the message and 2 for followup edits

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not possible
  • 📘 API documentation in docs/ has been updated or is not required
  • 🔖 Capability is added or not needed

@nickvergessen nickvergessen added 2. developing feature: chat 💬 Chat and system messages feature: api 🛠️ OCS API for conversations, chats and participants labels Jan 10, 2024
@nickvergessen nickvergessen added this to the 💞 Next Major (29) milestone Jan 10, 2024
@nickvergessen nickvergessen self-assigned this Jan 10, 2024
@nickvergessen nickvergessen force-pushed the feat/11206/edit-message-mentions branch from 9631669 to 0cb4a0c Compare January 10, 2024 12:08
@nickvergessen nickvergessen marked this pull request as draft January 10, 2024 12:21
@nickvergessen nickvergessen force-pushed the feat/11206/edit-message-mentions branch 3 times, most recently from 3f6de38 to c197479 Compare January 17, 2024 12:25
@nickvergessen nickvergessen marked this pull request as ready for review January 17, 2024 12:26
@nickvergessen
Copy link
Member Author

Ready for review @Ivansss @DorraJaouad

@nickvergessen nickvergessen mentioned this pull request Jan 17, 2024
Closed
18 tasks
@nickvergessen nickvergessen force-pushed the feat/11206/edit-message-mentions branch from c197479 to 6ed6950 Compare January 18, 2024 11:23
Ivansss
Ivansss approved these changes Jan 18, 2024
View reviewed changes
Copy link
Member

@Ivansss Ivansss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works 👍

@nickvergessen
Copy link
Member Author

Failing tests are fixed with guests app:
nextcloud/guests#1100

@nickvergessen nickvergessen merged commit c3c977c into main Jan 18, 2024
51 of 53 checks passed
@nickvergessen nickvergessen deleted the feat/11206/edit-message-mentions branch January 18, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ivansss Ivansss Ivansss approved these changes

@DorraJaouad DorraJaouad Awaiting requested review from DorraJaouad

Assignees

@nickvergessen nickvergessen

Labels
3. to review feature: api 🛠️ OCS API for conversations, chats and participants feature: chat 💬 Chat and system messages
Projects
None yet
Milestone
v19.0.0-beta.1
Development

Successfully merging this pull request may close these issues.
2 participants
@nickvergessen @Ivansss