Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show MediaSettings if coming from notification "Join call" #10724

Merged
merged 2 commits into from
Oct 18, 2023

Conversation

Antreesy
Copy link
Contributor

@Antreesy Antreesy commented Oct 17, 2023

☑️ Resolves

🖌️ UI Checklist

No visual changes

  • With opening from web client - redirect to the page, media settings dialog is shown
  • With opening from NC Desktop client - open new page in browser, media settings dialog is shown

🚧 Tasks

  • Talk Desktop - test with
  • Don't show previews for specific conversations:
    • BrowserStorage should be available atm
    • Or we force the dialog

🏁 Checklist


🛠️ API Checklist

🚧 Tasks

  • ...

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not possible
  • 📘 API documentation in docs/ has been updated or is not required
  • 🔖 Capability is added or not needed

@Antreesy Antreesy self-assigned this Oct 17, 2023
@nickvergessen nickvergessen force-pushed the feat/7038/enable-direct-call branch from 0f3b373 to 8d3e6ff Compare October 18, 2023 10:13
Copy link
Member

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed eslint and pushed the backend. Works great!

@nickvergessen nickvergessen added this to the 💙 Next Major (28) milestone Oct 18, 2023
@nickvergessen nickvergessen added 3. to review enhancement feature: api 🛠️ OCS API for conversations, chats and participants feature: frontend 🖌️ "Web UI" client feature: call 📹 Voice and video calls labels Oct 18, 2023
@Antreesy
Copy link
Contributor Author

Button Join call leads to correct link:
image
But Answer call does not:
image

Should be fixed on Desktop client side though, it is edited manually, iirc

@Antreesy
Copy link
Contributor Author

Talk Desktop Client uses notification link when it shows a native system notification, not notification action link:
image
As root link should not be modified (Desktop may use it to reply in chat), Talk Desktop can use a link from actions[0], if it exists

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review enhancement feature: api 🛠️ OCS API for conversations, chats and participants feature: call 📹 Voice and video calls feature: frontend 🖌️ "Web UI" client
Projects
None yet
Development

Successfully merging this pull request may close these issues.

📲 Add controller URL which opens directly the call/device checker
2 participants