Request a valid property for DAV opendir #9955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apperently Sabre and Onedrive are not friends when requesting a single 404 property. I need to dig deeper on why this is. Anyways requesting a valid property makes it work like a charm. Signed-off-by: Roeland Jago Douma <[email protected]>
rullzer
requested review from
nickvergessen,
MorrisJobke,
icewind1991 and
blizzz
Codecov Report
@@ Coverage Diff @@
## master #9955 +/- ##
=========================================
Coverage 52.08% 52.08%
Complexity 25944 25944
=========================================
Files 1645 1645
Lines 95828 95828
Branches 1290 1290
=========================================
Hits 49916 49916
Misses 45912 45912
|
MorrisJobke
approved these changes
Jun 21, 2018
icewind1991
approved these changes
Jun 22, 2018
|
What about the backport? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apperently Sabre and Onedrive (webdav endpoin) are not friends when requesting a single
404 property. I need to dig deeper on why this is. Anyways requesting a
valid property makes it work like a charm.
Signed-off-by: Roeland Jago Douma [email protected]