Ldap password renewal fixes for NC13 #9288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Roger Szabo <[email protected]>
Signed-off-by: Roger Szabo <[email protected]>
MorrisJobke
reviewed
Apr 24, 2018
apps/user_ldap/css/renewPassword.css
Outdated
| width:0; | ||
| height:0; | ||
| border-color:transparent; | ||
| border-style:solid |
There was a problem hiding this comment.
Could I ask you to have them same indention level as in the previous lines.
There was a problem hiding this comment.
Oh yeah sure, done now with commit "css indent alignment"
Signed-off-by: Roger Szabo <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #9288 +/- ##
============================================
- Coverage 51.94% 51.93% -0.02%
- Complexity 25383 25389 +6
============================================
Files 1608 1608
Lines 95423 95435 +12
Branches 1394 1394
============================================
- Hits 49571 49563 -8
- Misses 45852 45872 +20
|
Signed-off-by: Roger Szabo <[email protected]>
|
cc @nextcloud/ldap |
Is it specific to that page, or useful for nextcloud in general? |
Specific to that page. |
blizzz
approved these changes
Apr 27, 2018
|
needs another reviewer |
rullzer
approved these changes
May 12, 2018
|
Backport is in #9661 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
The "Renew Password" page in user_ldap needed minor adjustments to keep it aligned with NC13 core changes:
Commit "adjust css to nc13 core changes"
Since NC 13 the "Renew Password" page doesn't load the
server.scssanymore, so tooltip related CSS is copied over torenewPassword.cssuntil issue server.scss for login pages #9251 is solved. The commit also includes a minor adjustment in label position and button background colorCommit "remove reset password link"
The reset password function in core has been heavily revamped, so instead of updating the "Renew Password" page with this now quite complicated function, the reset password link is now removed completely from the "Renew Password" page. This is because such feature isn't needed on the "Renew Password" page anyway, and here's why: