Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix undefined variable - found by Phan #9271

Merged
merged 3 commits into from
Apr 23, 2018
Merged

Conversation

MorrisJobke
Copy link
Member

Added in #2744

Found by Phan (#8375):

lib/private/Files/Storage/DAV.php:773 PhanUndeclaredVariable Variable $e is undeclared

@MorrisJobke
Copy link
Member Author

Left over from a refactoring

#1940

Signed-off-by: Morris Jobke <[email protected]>
@codecov
Copy link

codecov bot commented Apr 23, 2018

Codecov Report

Merging #9271 into master will decrease coverage by <.01%.
The diff coverage is 33.33%.

@@             Coverage Diff              @@
##             master    #9271      +/-   ##
============================================
- Coverage     51.95%   51.95%   -0.01%     
+ Complexity    25375    25373       -2     
============================================
  Files          1607     1607              
  Lines         95393    95392       -1     
  Branches       1394     1394              
============================================
- Hits          49559    49557       -2     
- Misses        45834    45835       +1
Impacted Files Coverage Δ Complexity Δ
lib/private/Files/Storage/DAV.php 65.18% <0%> (ø) 159 <0> (ø) ⬇️
lib/private/Files/ObjectStore/SwiftFactory.php 0% <0%> (ø) 37 <0> (ø) ⬇️
lib/private/Installer.php 58.39% <100%> (-0.16%) 71 <0> (-2)
lib/private/Files/Cache/Propagator.php 94.93% <0%> (-1.27%) 16% <0%> (ø)

@MorrisJobke
Copy link
Member Author

Added another leftover from a refactoring: #1940

@nickvergessen nickvergessen merged commit 05a6b71 into master Apr 23, 2018
@nickvergessen nickvergessen deleted the fix-undefined-variable branch April 23, 2018 13:51
@MorrisJobke
Copy link
Member Author

Backport in #9651

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants