-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix undefined variable - found by Phan #9271
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Morris Jobke <[email protected]>
Added in https://github.com/nextcloud/server/pull/8314/files#diff-a55c10804586cd797b7f3f16556c1457R157 Signed-off-by: Morris Jobke <[email protected]>
And another one which was added in https://github.com/nextcloud/server/pull/8314/files#diff-a55c10804586cd797b7f3f16556c1457R157 |
Left over from a refactoring #1940 Signed-off-by: Morris Jobke <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #9271 +/- ##
============================================
- Coverage 51.95% 51.95% -0.01%
+ Complexity 25375 25373 -2
============================================
Files 1607 1607
Lines 95393 95392 -1
Branches 1394 1394
============================================
- Hits 49559 49557 -2
- Misses 45834 45835 +1
|
Added another leftover from a refactoring: #1940 |
nickvergessen
approved these changes
Apr 23, 2018
icewind1991
approved these changes
Apr 23, 2018
Backport in #9651 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added in #2744
Found by Phan (#8375):