New user button to sidebar

[skjnldsv]

Fix #6746
Fix #7162
@nextcloud/designers

• Do we need the confirm submit button?
• On mobile, clicking the new button hides the sidebar
• Update documentation

[juliusknorr]

I'm not that sure if we should go with a popover here. I'd rather use the solution @jancborchardt proposed in #7162:

That would add a new row in the content area on top of the table, with empty fields and dropdowns using default values, with the username field focused.

Makes much more sense to enter the new user data inline where it will appear later on as well.

[pixelipo]

I agree with @juliushaertl - also because @jancborchardt 's proposed solution would also solve #6468

[skjnldsv]

Okay :)

[MariusBluem]

Even if I am the only one maybe, I like the proposed change.

1. moving the „Add user“ button into the sidebar makes sense, since Mail and Contacts have the button at the same place. It makes the interface more clean and - at least for me - more easy to use. I would even love to see this in the Files UI.

2. we can discuss the design of the appearing dropdown, there may be place for polishing.

[pixelipo]

Nobody is contesting moving the Add button to the sidebar - that is a good solution. It's just that the button shouldn't open a popover, by rather create a new row with input fields in the main container.

It's a UX general rule of thumb that models should be used rarely.

In this particular example it's easy to create a usability issue - lose focus from popover and what happens with data that was already input?

[MariusBluem]

Ah ... okay, sorry for the misunderstanding :)

[MariusBluem]

maybe we should remove the "+add group" button by doing this ... looks strange having to such buttons in the sidebar (with one more prominent than the other) .. "+ add group" is not needed since a group can be created by simply adding an non-existing group to a user. What do you think @nextcloud/designers

[skjnldsv]

I agree with @MariusBluem

[jancborchardt]

Let's keep separate things separate. :)

This issue is about redoing the "Add new user" flow. This includes adding a button in the sidebar (good start @skjnldsv!), which then adds a new row with inputs at the top of the list like I described and as @juliushaertl referemced above.

What we do with the "Add group" button is separate from this and should not block it.

[codecov]

Codecov Report

Merging #7600 into master will decrease coverage by <.01%.
The diff coverage is 0%.

@@             Coverage Diff             @@
##             master   #7600      +/-   ##
===========================================
- Coverage      51.9%   51.9%   -0.01%     
  Complexity    25434   25434              
===========================================
  Files          1609    1609              
  Lines         95365   95380      +15     
  Branches       1378    1378              
===========================================
+ Hits          49502   49505       +3     
- Misses        45863   45875      +12

Impacted Files	Coverage Δ	Complexity Δ
settings/templates/users/main.php	0% <ø> (ø)	0 <0> (ø)	⬇️
settings/templates/users/part.userlist.php	0% <0%> (ø)	0 <0> (ø)	⬇️
settings/templates/users/part.createuser.php	0% <0%> (ø)	0 <0> (ø)	⬇️
apps/files_trashbin/lib/Trashbin.php	72.46% <0%> (-0.25%)	136% <0%> (ø)
lib/private/Files/Cache/Propagator.php	96.2% <0%> (+1.26%)	16% <0%> (ø)	⬇️
lib/private/Files/ObjectStore/SwiftFactory.php	56.32% <0%> (+3.44%)	35% <0%> (ø)	⬇️

[skjnldsv]

Okay, pr updated, left to do:

• Dropdown select off by 2 px
  

[jancborchardt]

@skjnldsv sorry for the confusion, but the placement is still off. ;)

That would add a new row in the content area on top of the table […]

So it would look like a new row already, above the other user rows. Basically exactly like it is when you edit a user.

That way it's symmetric for people to use, and we don't have to maintain 2 separate interfaces. :)

[skjnldsv]

Ahahaha I'm a fool :p
Apparently I forgot how to read 😆

[skjnldsv]

Okay, what do you think now? @jancborchardt

[jancborchardt]

Looks great! :) Just change the button label from "Create" to "Add user" (as we never use "Create") and it's good.

Please also check @nextcloud/designers :)

[MariusBluem]

Why dont you put the „Add User“ arrow in a line together with the 3-dot-menu. This would make room for additional settings like Group Admin, Quota and maybe E-Mail (according to what is shown/enabled) already while adding the user. What do you think? @jancborchardt

[skjnldsv]

Why dont you put the „Add User“ arrow in a line together with the 3-dot-menu. This would make room for additional settings like Group Admin, Quota and maybe E-Mail (according to what is shown/enabled) already while adding the user. What do you think? @jancborchardt

I did at first, but we have multiple rows columns hidden. So if the user choose to display all of them (in the settings) the create button goes outside the window :(

[jancborchardt]

@MariusBluem @skjnldsv yeah, I also saw it but came to the conclusion it’s fine. :) In the future we can improve it and show whatever people display, but this is fine for now.

[jancborchardt]

@skjnldsv could you make sure the first field »Username« is automatically focused when the button is clicked and row is created?

[jancborchardt]

I fixed the wording to "Add user". :)

[rullzer]

Works as advertised!

[skjnldsv]

[skjnldsv]

Wait a bit before merging please @rullzer

OKAY now

[MorrisJobke]

Acceptance tests fail:

cenario: log in with invalid user once fixed by admin              # /drone/src/github.com/nextcloud/server/tests/acceptance/features/login.feature:32
    Given I act as John                                               # ActorContext::iActAs()
    And I can not log in with user unknownUser and password 123456acb # LoginPageContext::iCanNotLogInWithUserAndPassword()
    When I act as Jane                                                # ActorContext::iActAs()
    And I am logged in as the admin                                   # LoginPageContext::iAmLoggedInAsTheAdmin()
    And I open the User settings                                      # SettingsMenuContext::iOpenTheUserSettings()
    And I create user unknownUser with password 123456acb             # UsersSettingsContext::iCreateUserWithPassword()
      │ User name field for new user in Users Settings value could not be set
      │ Exception message: Element is not currently visible and so may not be interacted with
      │ Build info: version: '2.53.1', revision: 'a36b8b1', time: '2016-06-30 17:37:03'
      │ System info: host: '47d48347a2f2', ip: '172.17.0.13', os.name: 'Linux', os.arch: 'amd64', os.version: '4.4.0-96-generic', java.version: '1.8.0_91'
      │ Driver info: driver.version: unknown
      │ Trying again
      │
      Element is not currently visible and so may not be interacted with

[skjnldsv]

And I set the password for user0 to 654321                               # UsersSettingsContext::iSetThePasswordForUserTo()
  Offset within element cannot be scrolled into view: (0, 0): [object HTMLTableCellElement]
  Build info: version: '2.53.1', revision: 'a36b8b1', time: '2016-06-30 17:37:03'
  System info: host: 'a18942a51f1e', ip: '172.17.0.17', os.name: 'Linux', os.arch: 'amd64', os.version: '4.4.0-96-generic', java.version: '1.8.0_91'
  Driver info: driver.version: unknown (WebDriver\Exception\MoveTargetOutOfBounds)

Fixed most of it, will see tomorrow if danxuliu did not picked this up before me :)

[MariusBluem]

Will you integrate nextcloud/bookmarks#424 (comment) in this PR?

[skjnldsv]

@MariusBluem in a later pr. Do you recall where it was discussed before ? 🤔

[danxuliu]

The acceptance tests should all work now; I have squashed all the fixes related to the acceptance tests in a single commit.

[skjnldsv]

Failure unrelated.
Acceptance now passes