-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add app content list #7195
Add app content list #7195
Conversation
Signed-off-by: John Molakvoæ (skjnldsv) <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #7195 +/- ##
============================================
+ Coverage 50.79% 50.84% +0.04%
- Complexity 24488 24546 +58
============================================
Files 1582 1585 +3
Lines 93619 93797 +178
Branches 1354 1354
============================================
+ Hits 47552 47688 +136
- Misses 46067 46109 +42
|
Signed-off-by: John Molakvoæ (skjnldsv) <[email protected]>
Awesome! Let’s review this @nextcloud/designers! :) @skjnldsv this is still marked as »developing«, is that correct? |
I'll finish it up tomorrow :) |
@skjnldsv @jancborchardt would be great to wait mentioning or assigning reviews until it's actually ready to be reviewed. Otherwise this results in notification spam with every single commit and comment. Thanks. |
Signed-off-by: John Molakvoæ (skjnldsv) <[email protected]>
Sorry!! 🙈 😅 Updated test template: templatetest.tar.gz |
Signed-off-by: Jan-Christoph Borchardt <[email protected]>
Signed-off-by: Jan-Christoph Borchardt <[email protected]>
Signed-off-by: Jan-Christoph Borchardt <[email protected]>
Added some fixes, it’s good to go now imo. What did you want to change @skjnldsv? |
Ahaha, did not have time to check :D |
Great work @skjnldsv! :) So do we now backport this to stable12, and at the same time add it to the Mail and Contacts apps too for backwards compatibility? Or just that, without backporting? |
Thanks! No! Backporting, makes no sense for new features stuff, unless it's a bug :) |
Btw @daita this should be implemented by Circles as well so it fits with the overall Nextcloud design. :) Design guidelines for other components you can find at https://docs.nextcloud.com/server/12/developer_manual/design/ |
Fix #6612
This implements the app content list standardisation across apps.
Updated test template: templatetest.tar.gz
@nextcloud/designers