Add Skeleton for a PublicShareController #6760
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rullzer
force-pushed
the
publicshare-general
branch
2 times, most recently
from
6a0ac15 to
4e10d43
Compare
This will allow apps to use a generic controller for public pages. This should allow easier bug fixing and hardening instead of doing it for each and every app. Signed-off-by: Roeland Jago Douma <[email protected]>
Signed-off-by: Roeland Jago Douma <[email protected]>
rullzer
force-pushed
the
publicshare-general
branch
from
4e10d43 to
a99016d
Compare
|
I need to think and polish this more. I'll won't do that this week so lets move it to 14 |
|
@rullzer still the way to go? |
|
Yeah it is. But it needs more thinking. Let me close this for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow apps to use a generic controller for public pages.
This should allow easier bug fixing and hardening instead of doing it
for each and every app.
@LukasReschke as discussed
TODO: