Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inputs border to main bg and fix white inputs #6692

Merged
merged 4 commits into from
Oct 10, 2017
Merged

Conversation

skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Sep 28, 2017

During the variable pr, the white radio/checkboxes have been broken.
They need to be base on the white colour only, and not relative to the text colour or bg colour.

Therefore, this is fixed.

On the other hand, the border & bg of the inputs needs to be based on the main background colour, not the text. This will ensure a better contrast! :)

@nextcloud/designers

@skjnldsv skjnldsv added 3. to review Waiting for reviews design Design, UI, UX, etc. regression labels Sep 28, 2017
@skjnldsv skjnldsv added this to the Nextcloud 13 milestone Sep 28, 2017
@skjnldsv skjnldsv self-assigned this Sep 28, 2017
@codecov
Copy link

codecov bot commented Sep 28, 2017

Codecov Report

❗ No coverage uploaded for pull request base (master@060eac4). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #6692   +/-   ##
=========================================
  Coverage          ?   30.71%           
  Complexity        ?     1466           
=========================================
  Files             ?       94           
  Lines             ?     5148           
  Branches          ?        0           
=========================================
  Hits              ?     1581           
  Misses            ?     3567           
  Partials          ?        0

@skjnldsv
Copy link
Member Author

skjnldsv commented Oct 3, 2017

Bump? 😭

@juliusknorr
Copy link
Member

juliusknorr commented Oct 4, 2017

@skjnldsv Maybe you can add some variables for the border color values? Otherwise it will get messy to maintain those different transparency levels used.

The rest looks good 👍

@skjnldsv
Copy link
Member Author

skjnldsv commented Oct 4, 2017

Hum, it's not supposed to be edited. But it doesn't hurt I guess! :)

Signed-off-by: John Molakvoæ (skjnldsv) <[email protected]>
Signed-off-by: John Molakvoæ (skjnldsv) <[email protected]>
Signed-off-by: John Molakvoæ (skjnldsv) <[email protected]>
@skjnldsv skjnldsv force-pushed the inputs-border-to-main-bg branch from bbd1997 to 27a6bbc Compare October 4, 2017 13:42
@skjnldsv
Copy link
Member Author

skjnldsv commented Oct 4, 2017

@juliushaertl Done ;)
I don't want to add this to the variable.scss since it's not supposed to be changeable. It's just to be easier to understand.

Signed-off-by: John Molakvoæ (skjnldsv) <[email protected]>
@skjnldsv skjnldsv force-pushed the inputs-border-to-main-bg branch from 91df287 to c2abc58 Compare October 4, 2017 14:11
@skjnldsv
Copy link
Member Author

@nextcloud/designers the drone fails but not because of this :)

@rullzer rullzer merged commit 968d4f6 into master Oct 10, 2017
@rullzer rullzer deleted the inputs-border-to-main-bg branch October 10, 2017 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews design Design, UI, UX, etc. regression
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants