-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inputs border to main bg and fix white inputs #6692
Conversation
Codecov Report
@@ Coverage Diff @@
## master #6692 +/- ##
=========================================
Coverage ? 30.71%
Complexity ? 1466
=========================================
Files ? 94
Lines ? 5148
Branches ? 0
=========================================
Hits ? 1581
Misses ? 3567
Partials ? 0 |
Bump? 😭 |
@skjnldsv Maybe you can add some variables for the border color values? Otherwise it will get messy to maintain those different transparency levels used. The rest looks good 👍 |
Hum, it's not supposed to be edited. But it doesn't hurt I guess! :) |
Signed-off-by: John Molakvoæ (skjnldsv) <[email protected]>
Signed-off-by: John Molakvoæ (skjnldsv) <[email protected]>
Signed-off-by: John Molakvoæ (skjnldsv) <[email protected]>
bbd1997
to
27a6bbc
Compare
@juliushaertl Done ;) |
Signed-off-by: John Molakvoæ (skjnldsv) <[email protected]>
91df287
to
c2abc58
Compare
@nextcloud/designers the drone fails but not because of this :) |
During the variable pr, the white radio/checkboxes have been broken.
They need to be base on the white colour only, and not relative to the text colour or bg colour.
Therefore, this is fixed.
On the other hand, the border & bg of the inputs needs to be based on the main background colour, not the text. This will ensure a better contrast! :)
@nextcloud/designers