Expire federation jobs #5923
Merged
Expire federation jobs #5923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schiessle
added
3. to review
Signed-off-by: Bjoern Schiessle <[email protected]>
Signed-off-by: Bjoern Schiessle <[email protected]>
Signed-off-by: Bjoern Schiessle <[email protected]>
Signed-off-by: Bjoern Schiessle <[email protected]>
…re the other server will decline and the background job will be removed Signed-off-by: Bjoern Schiessle <[email protected]>
* Inject the timefacotry so we can mock it properly in the tests. * Extended unit tests to cover the new paths Signed-off-by: Roeland Jago Douma <[email protected]>
rullzer
force-pushed
the
expire-federation-jobs
branch
from
0560bd5 to
bc54e6f
Compare
Codecov Report
@@ Coverage Diff @@
## master #5923 +/- ##
===========================================
+ Coverage 53.06% 53.1% +0.04%
+ Complexity 22761 22757 -4
===========================================
Files 1404 1404
Lines 88064 88112 +48
Branches 1327 1327
===========================================
+ Hits 46730 46795 +65
+ Misses 41334 41317 -17
|
rullzer
approved these changes
Aug 1, 2017
| @@ -74,7 +75,8 @@ private function registerService() { | |||
| $server->getJobList(), | |||
| $server->getSecureRandom(), | |||
| $server->getConfig(), | |||
| $server->getEventDispatcher() | |||
| $server->getEventDispatcher(), | |||
| $server->query(ITimeFactory::class) | |||
There was a problem hiding this comment.
It should work without this.
I will try it.
Signed-off-by: Joas Schilling <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
|
Cleaned it up a bit, works 👍 |
nickvergessen
approved these changes
Aug 2, 2017
nickvergessen
added
4. to release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After trying for 30 days to create a trusted server relationship without success we kill the background job.
Might also prevent things like: #5880