Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable30] fix(theming): Do not throw in background color migration #50554

Merged
merged 2 commits into from
Jan 31, 2025
Merged

[stable30] fix(theming): Do not throw in background color migration #50554

merged 2 commits into from
Jan 31, 2025

Conversation

backportbot[bot]
Copy link

@backportbot backportbot bot commented Jan 30, 2025

Backport of PR #50503

@backportbot backportbot bot added this to the Nextcloud 30.0.6 milestone Jan 30, 2025
@susnux susnux force-pushed the backport/50503/stable30 branch from 23dbd54 to 2d8432f Compare January 30, 2025 07:45
@juliusknorr
Copy link
Member

@susnux Failures seem related

There were 2 errors:

1) OCA\Theming\Tests\Migration\Version2006Date20240905111627Test::testRestoreUserColors
Error: Call to undefined method OC\AllConfig::clearCache()

/home/runner/actions-runner/_work/server/server/apps/theming/tests/Migration/Version2006Date20240905111627Test.php:118

2) OCA\Theming\Tests\Migration\Version2006Date20240905111627Test::testRestoreUserColorsWithConflicts
InvalidArgumentException: The Login is already being used

/home/runner/actions-runner/_work/server/server/lib/private/User/Manager.php:441
/home/runner/actions-runner/_work/server/server/lib/private/User/Manager.php:409
/home/runner/actions-runner/_work/server/server/apps/theming/tests/Migration/Version2006Date20240905111627Test.php:142

@susnux
Copy link
Contributor

susnux commented Jan 30, 2025

Failures seem related

Yes UserConfig is 31 only, will fix this.

@susnux susnux force-pushed the backport/50503/stable30 branch from 2d8432f to 09003e5 Compare January 31, 2025 19:19
@susnux susnux force-pushed the backport/50503/stable30 branch from 09003e5 to 6d3bdbc Compare January 31, 2025 19:29
@susnux susnux merged commit b58e072 into stable30 Jan 31, 2025
171 checks passed
@susnux susnux deleted the backport/50503/stable30 branch January 31, 2025 19:54
@Altahrim Altahrim mentioned this pull request Feb 5, 2025
Merged
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@susnux susnux susnux approved these changes

@artonge artonge artonge approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@provokateurin provokateurin provokateurin approved these changes

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

@juliusknorr juliusknorr Awaiting requested review from juliusknorr juliusknorr is a code owner

Assignees

@susnux susnux

Labels
3. to review Waiting for reviews bug feature: theming
Projects
None yet
Milestone
Nextcloud 30.0.6
Development

Successfully merging this pull request may close these issues.
5 participants
@juliusknorr @susnux @artonge @skjnldsv @provokateurin