Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable30] fix: replace null character when serializing #49855

Merged
merged 1 commit into from
Dec 14, 2024
Merged

[stable30] fix: replace null character when serializing #49855

merged 1 commit into from
Dec 14, 2024
+96 −2

Conversation

backportbot[bot]
Copy link

@backportbot backportbot bot commented Dec 14, 2024 •
edited by SebastianKrupinski
Loading

Backport of #49528

Warning, This backport's changes differ from the original and might be incomplete ⚠️

Todo

  • Review and resolve any conflicts
  • Amend HEAD commit to remove the line stating to skip CI

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@backportbot backportbot bot added the 3. to review Waiting for reviews label Dec 14, 2024
@backportbot backportbot bot added this to the Nextcloud 30.0.5 milestone Dec 14, 2024
@SebastianKrupinski SebastianKrupinski marked this pull request as ready for review December 14, 2024 01:32
@SebastianKrupinski
Copy link
Contributor

SebastianKrupinski commented Dec 14, 2024 •
edited
Loading

Was missing "new RemoveBrokenProperties(\OC::$server->getDatabaseConnection())," in getExpensiveRepairSteps from original

@SebastianKrupinski SebastianKrupinski merged commit 0a87190 into stable30 Dec 14, 2024
171 checks passed
@SebastianKrupinski SebastianKrupinski deleted the backport/49528/stable30 branch December 14, 2024 09:40
@skjnldsv
Copy link
Member

Missing "new RemoveBrokenProperties(\OC::$server->getDatabaseConnection())," in getExpensiveRepairSteps from original

Was that addressed?

@SebastianKrupinski
Copy link
Contributor

SebastianKrupinski commented Dec 14, 2024 •
edited
Loading

Missing "new RemoveBrokenProperties(\OC::$server->getDatabaseConnection())," in getExpensiveRepairSteps from original

Was that addressed?

Yes, edited the comment to make it less confusing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SebastianKrupinski SebastianKrupinski SebastianKrupinski approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

@tcitworld tcitworld Awaiting requested review from tcitworld

Assignees

@SebastianKrupinski SebastianKrupinski

Labels
3. to review Waiting for reviews
Projects
None yet
Milestone
Nextcloud 30.0.5
Development

Successfully merging this pull request may close these issues.
2 participants
@SebastianKrupinski @skjnldsv