Improve select handling for sharded queries #49832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
icewind1991
commented
Dec 12, 2024
icewind1991
commented
- handle calling select on partitioned queries with an array of columns
- improve dealing with selecting query functions
- when ensuring that join columns are selected, take the partition into account
…lumns Signed-off-by: Robin Appelman <[email protected]>
…oned queries Signed-off-by: Robin Appelman <[email protected]>
icewind1991
requested review from
a team,
Altahrim,
nfebe and
sorbaugh
and removed request for
a team
provokateurin
approved these changes
Dec 12, 2024
skjnldsv
approved these changes
Dec 12, 2024
|
/backport to stable30 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.