Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add sse_c_key from S3 object storage properties config to list of sensitive values #49681

Merged
merged 1 commit into from
Dec 20, 2024

Conversation

rriemann
Copy link
Contributor

@rriemann rriemann commented Dec 5, 2024

Summary

Some logs (e.g. occ config:list) show encryption keys in clear. Let's redact this value!

Checklist

@solracsf solracsf added this to the Nextcloud 31 milestone Dec 6, 2024
@solracsf solracsf added the 3. to review Waiting for reviews label Dec 6, 2024
Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

@nickvergessen nickvergessen requested review from a team, Altahrim, artonge and skjnldsv and removed request for a team December 20, 2024 02:29
@skjnldsv skjnldsv merged commit c249df6 into nextcloud:master Dec 20, 2024
174 of 178 checks passed
Copy link

welcome bot commented Dec 20, 2024

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22

@skjnldsv
Copy link
Member

/backport to stable30

@skjnldsv
Copy link
Member

/backport to stable29

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants