Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Correct wording when attempting to remove a disabled app #49637

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

Pytal
Copy link
Member

@Pytal Pytal commented Dec 3, 2024

Summary

Fixes the confusing wording due to the mismatch between method name vs what the method actually does

* Check if an app is enabled in the instance

Checklist

@Pytal Pytal added this to the Nextcloud 31 milestone Dec 3, 2024
@Pytal Pytal requested review from skjnldsv, come-nc and a team December 3, 2024 22:43
@Pytal Pytal self-assigned this Dec 3, 2024
@Pytal Pytal requested review from artonge and removed request for a team December 3, 2024 22:43
@Pytal Pytal enabled auto-merge December 3, 2024 22:44
Copy link
Contributor

@come-nc come-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should rename the method and the related ones, it’s highly confusing.
I’m not sure I understand how getInstalledAppsValues is working and what it’s doing.

@come-nc
Copy link
Contributor

come-nc commented Dec 4, 2024

Ah, enabled can contain a list of group ids, this is what I was missing.
I may open a PR to improve the app manager.

@Pytal Pytal merged commit 416c8ea into master Dec 4, 2024
188 checks passed
@Pytal Pytal deleted the fix/app-remove-wording branch December 4, 2024 13:15
@skjnldsv skjnldsv mentioned this pull request Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants