-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(config): implementation of lexicon #49399
Open
ArtificialOwl
wants to merge
2
commits into
master
Choose a base branch
from
feature/noid/config-lexicon
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+880
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArtificialOwl
added
2. developing
Work in progress
pending documentation
This pull request needs an associated documentation update
enhancement
labels
Nov 20, 2024
ArtificialOwl
force-pushed
the
feature/noid/config-lexicon
branch
2 times, most recently
from
November 20, 2024 15:27
57c612f
to
7ac507e
Compare
ArtificialOwl
force-pushed
the
feature/noid/config-lexicon
branch
5 times, most recently
from
December 6, 2024 10:35
c8d65a4
to
31972cb
Compare
ArtificialOwl
added
3. to review
Waiting for reviews
and removed
2. developing
Work in progress
labels
Dec 6, 2024
come-nc
reviewed
Dec 12, 2024
come-nc
reviewed
Dec 12, 2024
come-nc
reviewed
Dec 12, 2024
come-nc
reviewed
Dec 12, 2024
come-nc
approved these changes
Dec 12, 2024
4 tasks
ArtificialOwl
force-pushed
the
feature/noid/config-lexicon
branch
3 times, most recently
from
December 12, 2024 22:27
c8b5562
to
fa36927
Compare
Signed-off-by: Maxence Lange <[email protected]>
Signed-off-by: Maxence Lange <[email protected]>
ArtificialOwl
force-pushed
the
feature/noid/config-lexicon
branch
from
December 13, 2024 12:39
fa36927
to
8159917
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
3. to review
Waiting for reviews
enhancement
pending documentation
This pull request needs an associated documentation update
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A
Config Lexicon
is a list of config keys used by current app. Each entry also define the expected type for the config value, its lazyness/sensitivity.The loading is done by registering a
IConfigLexicon
.Application.php
ConfigLexicon.php
Note: A description of the config key can be added as 3rd parameter of the
ConfigLexiconEntry
. This information is not stored when running from a web process.store and retrieve config value
Once this is done:
any code trying to wrongly type config values will get an exception
set/get on config values set as lazy will work even if not specified in the process
default value can be overwritten
will returns
42
ConfigLexiconStrictness
define the behavior when setting an unlisted config key:::IGNORE
: does not limit theset
/get
on an unknown config key::NOTICE
: does not limit theset
/get
on an unknown config key, but generate a notice in the logs::WARNING
: unknown config key will not beset
, andget
will returns the default value. A warning will be issued in the logs::EXCEPTION
:set
/get
on an unknown config key will generate an exceptionAlso, setting a config key as deprecated will generate a level 1 log entry when the config key is used