-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(richobjectstrings): Add missing placeholder validation #49116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joas Schilling <[email protected]>
provokateurin
approved these changes
Nov 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Joas Schilling <[email protected]>
provokateurin
approved these changes
Nov 7, 2024
come-nc
requested changes
Nov 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good apart from typo
Signed-off-by: Joas Schilling <[email protected]>
come-nc
approved these changes
Nov 7, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
3. to review
Waiting for reviews
bug
pending documentation
This pull request needs an associated documentation update
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Some apps were using placeholders with spaces, @ and slashes. But the frontend only allowed
[a-z\-_.0-9]+
https://github.com/nextcloud-libraries/nextcloud-vue/blob/master/src/components/NcRichText/NcRichText.vue#L396-L397
At the same time, using
0-9
only would break in PHP as that makes it not a string anymore but a number, so additionally we now require the placeholder to start witha-zA-Z
The recommended workaround is to not use "user ids" and other things directly, but instead using hardcoded strings like
actor
or "counting keys" likeuser-1
, similar to how comments does it on it's activities:server/apps/comments/lib/Activity/Provider.php
Line 110 in 096f893
server/apps/comments/lib/Activity/Provider.php
Line 162 in 096f893
Checklist