Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable25] fix(dav): Always respond custom error page on exceptions #48304

Merged
merged 5 commits into from
Oct 1, 2024

fix: Disable constructor in ErrorPagePluginTest

fc6ab73
Select commit
Loading
Failed to load commit list.
Merged

[stable25] fix(dav): Always respond custom error page on exceptions #48304

fix: Disable constructor in ErrorPagePluginTest
fc6ab73
Select commit
Loading
Failed to load commit list.
GitHub Advanced Security / Psalm succeeded Sep 30, 2024 in 3s

14 new alerts

New alerts in code changed by this pull request

  • 14 notes

See annotations below for details.

View all branch alerts.

Annotations

Check notice on line 64 in apps/dav/lib/Files/ErrorPagePlugin.php

See this annotation in the file changed.

Code scanning / Psalm

PossiblyNullArgument Note

Argument 1 of Sabre\DAV\Exception::getHTTPHeaders cannot be null, possibly null value provided

Check notice on line 69 in apps/dav/lib/Files/ErrorPagePlugin.php

See this annotation in the file changed.

Code scanning / Psalm

PossiblyNullPropertyFetch Note

Cannot get property on possibly null variable $this->server of type Sabre\DAV\Server|null

Check notice on line 69 in apps/dav/lib/Files/ErrorPagePlugin.php

See this annotation in the file changed.

Code scanning / Psalm

PossiblyNullReference Note

Cannot call method addHeaders on possibly null value

Check notice on line 92 in apps/dav/lib/Files/ErrorPagePlugin.php

See this annotation in the file changed.

Code scanning / Psalm

PossiblyNullPropertyFetch Note

Cannot get property on possibly null variable $this->server of type Sabre\DAV\Server|null

Check notice on line 92 in apps/dav/lib/Files/ErrorPagePlugin.php

See this annotation in the file changed.

Code scanning / Psalm

PossiblyNullReference Note

Cannot call method setHeader on possibly null value

Check notice on line 97 in apps/dav/lib/Files/ErrorPagePlugin.php

See this annotation in the file changed.

Code scanning / Psalm

PossiblyNullArgument Note

Argument 3 of OC_Template::__construct cannot be null, possibly null value provided

Check notice on line 98 in apps/dav/lib/Files/ErrorPagePlugin.php

See this annotation in the file changed.

Code scanning / Psalm

PossiblyNullPropertyFetch Note

Cannot get property on possibly null variable $this->server of type Sabre\DAV\Server|null

Check notice on line 98 in apps/dav/lib/Files/ErrorPagePlugin.php

See this annotation in the file changed.

Code scanning / Psalm

PossiblyNullReference Note

Cannot call method getStatusText on possibly null value

Check notice on line 114 in apps/dav/lib/Files/ErrorPagePlugin.php

See this annotation in the file changed.

Code scanning / Psalm

MissingReturnType Note

Method OCA\DAV\Files\ErrorPagePlugin::sendResponse does not have a return type, expecting void

Check notice on line 115 in apps/dav/lib/Files/ErrorPagePlugin.php

See this annotation in the file changed.

Code scanning / Psalm

PossiblyNullPropertyFetch Note

Cannot get property on possibly null variable $this->server of type Sabre\DAV\Server|null

Check notice on line 115 in apps/dav/lib/Files/ErrorPagePlugin.php

See this annotation in the file changed.

Code scanning / Psalm

PossiblyNullReference Note

Cannot call method sendResponse on possibly null value

Check notice on line 115 in apps/dav/lib/Files/ErrorPagePlugin.php

See this annotation in the file changed.

Code scanning / Psalm

PossiblyNullPropertyFetch Note

Cannot get property on possibly null variable $this->server of type Sabre\DAV\Server|null

Check notice on line 115 in apps/dav/lib/Files/ErrorPagePlugin.php

See this annotation in the file changed.

Code scanning / Psalm

PossiblyNullArgument Note

Argument 1 of Sabre\HTTP\Sapi::sendResponse cannot be null, possibly null value provided

Check notice on line 239 in apps/dav/lib/Server.php

See this annotation in the file changed.

Code scanning / Psalm

DeprecatedMethod Note

The method OC\Server::getConfig has been marked as deprecated