Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add application/zstd #48129

Merged
merged 2 commits into from
Sep 17, 2024
Merged

chore: add application/zstd #48129

merged 2 commits into from
Sep 17, 2024

Conversation

skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Sep 17, 2024

image

Remember to run occ maintenance:mimetype:update-db to manually update existing instances
fix #34892

Signed-off-by: John Molakvoæ (skjnldsv) <[email protected]>
@skjnldsv skjnldsv added enhancement 3. to review Waiting for reviews labels Sep 17, 2024
@skjnldsv skjnldsv added this to the Nextcloud 31 milestone Sep 17, 2024
@skjnldsv skjnldsv self-assigned this Sep 17, 2024
@skjnldsv skjnldsv requested review from ArtificialOwl, icewind1991 and nfebe and removed request for a team September 17, 2024 09:39
Copy link
Member

@rakekniven rakekniven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure about all changes here, but the zstd related lines look promising.

@skjnldsv
Copy link
Member Author

Yeah, I also sorted the other file, seems people were adding the changes at the end 🤷

@kesselb
Copy link
Contributor

kesselb commented Sep 17, 2024

Yeah, I also sorted the other file, seems people were adding the changes at the end 🤷

Thanks 🙏

@juliusknorr
Copy link
Member

In case you want to also support files that are already on existing instances, make sure to also add to the repair step:

private function updateMimetypes($updatedMimetypes): IResult|int|null {

@susnux
Copy link
Contributor

susnux commented Sep 17, 2024

make sure to also add to the repair step:

Yes please!

@skjnldsv
Copy link
Member Author

Done and sorted it by introduced version too

@skjnldsv skjnldsv enabled auto-merge September 17, 2024 12:04
Signed-off-by: John Molakvoæ (skjnldsv) <[email protected]>
@skjnldsv skjnldsv merged commit fe9981f into master Sep 17, 2024
174 checks passed
@skjnldsv skjnldsv deleted the feat/zst branch September 17, 2024 12:31
@skjnldsv skjnldsv mentioned this pull request Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support media type "zstd" and show archive icon
5 participants