[stable29] fix(theming): Don't reset the cachebuster value when we reset theming #46434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![backportbot[bot]](https://avatars.githubusercontent.com/in/60201?s=60&v=4){kind=small}
Signed-off-by: Marcel Müller <[email protected]>
SystemKeeper
approved these changes
Jul 11, 2024
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -460,7 +460,11 @@ | |||
| * Revert all settings to the default value | |||
| */ | |||
| public function undoAll(): void { | |||
| // Remember the current cachebuster value, as we do not want to reset this value | |||
| // Otherwise this can lead to caching issues as the value might be known to a browser already | |||
| $cacheBusterKey = $this->config->getAppValue('theming', 'cachebuster', '0'); | |||
Check notice
Code scanning / Psalm
DeprecatedMethod Note
| $this->config->deleteAppValues('theming'); | ||
| $this->config->setAppValue('theming', 'cachebuster', $cacheBusterKey); |
Check notice
Code scanning / Psalm
DeprecatedMethod Note
nickvergessen
approved these changes
Jul 11, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of PR #46428