-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix overlay of oc-dialog #44676
fix overlay of oc-dialog #44676
Conversation
- Icrement Z-index of oc-dialog-dim\ - Increment z-index of oc-dialog- Insert oc-dialog-dim before oc-dialog\ - Co-authored-by: Co-author RayanBekri <[email protected]>" Signed-off-by: JEEEEEEEEEEEEEEEEEEEEEED <[email protected]>
@susnux Thank you ! |
srr for the OT |
I think it is good, but we need to copy you PR inside our GitHub organization otherwise the Cypress tests will not run.
Yes it is and it is deprecated if you use jQuery -> ship your own. But Server might still use it until we found time for migrating all remaining places. We appreciate every community contributions! |
6b30587
into
nextcloud:fix/oc-dialog-overlay
Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22 |
Thank you very much for the pull request @jadjoud ! We really appreciate your contribution, and looking forward to more :) I copied into the organization so the Cypress tests can run and we can merge it into server! |
It's a pleasure to contribute into this community! |
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! |
Summary
Icrement Z-index of oc-dialog-dim\
Increment z-index of oc-dialog- Insert oc-dialog-dim before oc-dialog\
Co-authored-by: Co-author RayanBekri [email protected]" @RayanBekri
Signed-off-by: JEEEEEEEEEEEEEEEEEEEEEED [email protected]
Before:
After:
TODO
Checklist