Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix overlay of oc-dialog #44676

Merged
merged 2 commits into from
Apr 8, 2024

Conversation

jadjoud
Copy link
Contributor

@jadjoud jadjoud commented Apr 5, 2024

Summary

  • Icrement Z-index of oc-dialog-dim\

  • Increment z-index of oc-dialog- Insert oc-dialog-dim before oc-dialog\

  • Co-authored-by: Co-author RayanBekri [email protected]" @RayanBekri
    Signed-off-by: JEEEEEEEEEEEEEEEEEEEEEED [email protected]

Before:

bug-report

2024-03-26 14-35-52

After:

Nextcloud-Fix

TODO

  • ...

Checklist

jadjoud added 2 commits April 5, 2024 11:40
- Icrement Z-index of oc-dialog-dim\
- Increment z-index of oc-dialog- Insert oc-dialog-dim before oc-dialog\
- Co-authored-by: Co-author RayanBekri <[email protected]>"
Signed-off-by: JEEEEEEEEEEEEEEEEEEEEEED <[email protected]>
@susnux susnux added this to the Nextcloud 30 milestone Apr 5, 2024
@susnux susnux requested review from a team, Pytal, szaimen and emoral435 and removed request for a team April 5, 2024 11:55
@susnux susnux added bug 3. to review Waiting for reviews labels Apr 5, 2024
@jadjoud
Copy link
Contributor Author

jadjoud commented Apr 7, 2024

@susnux
Is there any needed changes regarding the 10 failed checks?
or i just need to wait for the 2 remaining reviews?

Thank you !

@Roman991
Copy link

Roman991 commented Apr 8, 2024

srr for the OT
but there'll be still Jquery in nextcloud v30?
no plans to deprecate it?

@susnux
Copy link
Contributor

susnux commented Apr 8, 2024

Is there any needed changes regarding the 10 failed checks?

I think it is good, but we need to copy you PR inside our GitHub organization otherwise the Cypress tests will not run.

But there'll be still Jquery in nextcloud v30?

Yes it is and it is deprecated if you use jQuery -> ship your own. But Server might still use it until we found time for migrating all remaining places. We appreciate every community contributions!

@susnux susnux changed the base branch from master to fix/oc-dialog-overlay April 8, 2024 11:31
@susnux susnux merged commit 6b30587 into nextcloud:fix/oc-dialog-overlay Apr 8, 2024
93 of 103 checks passed
Copy link

welcome bot commented Apr 8, 2024

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22

@susnux
Copy link
Contributor

susnux commented Apr 8, 2024

Thank you very much for the pull request @jadjoud ! We really appreciate your contribution, and looking forward to more :)

I copied into the organization so the Cypress tests can run and we can merge it into server!

@jadjoud
Copy link
Contributor Author

jadjoud commented Apr 8, 2024

Thank you very much for the pull request @jadjoud ! We really appreciate your contribution, and looking forward to more :)

I copied into the organization so the Cypress tests can run and we can merge it into server!

It's a pleasure to contribute into this community!
Looking forward to more contributions!

Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants