Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue #44487 #44514

Closed
wants to merge 19 commits into from
Closed

fix issue #44487 #44514

wants to merge 19 commits into from

Conversation

jadjoud
Copy link
Contributor

@jadjoud jadjoud commented Mar 27, 2024

Summary

The "Delete account" dialog opens on top of each other

  • Added an if statement to prevent reopening
  • Added an action method to Emitevent to notify UserRow component that an action has been performed

TODO

  • ...

Checklist

susnux and others added 3 commits March 28, 2024 00:24
…etically

We can do this purly in the frontend - but when enforced from the backend using the existing system config,
we need to follow the requirement. We then show a warning about the configuration.

Signed-off-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: JEEEEEEEEEEEEEEEEEEEEEED <[email protected]>
Signed-off-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: JEEEEEEEEEEEEEEEEEEEEEED <[email protected]>
Signed-off-by: JEEEEEEEEEEEEEEEEEEEEEED <[email protected]>
@solracsf solracsf marked this pull request as draft March 29, 2024 08:35
@jadjoud jadjoud marked this pull request as ready for review March 29, 2024 15:17
@jadjoud jadjoud changed the title fix issue #44487 (WIP Draft) fix issue #44487 (WIP) Mar 29, 2024
jadjoud added 12 commits March 30, 2024 00:38
Signed-off-by: JEEEEEEEEEEEEEEEEEEEEEED <[email protected]>
- Added an if condition for delete account and wiper user acount to mark the dialog as open
- Added an action methon to Emitevent to notify UserRow component that an action has been performed

Signed-off-by: JEEEEEEEEEEEEEEEEEEEEEED <[email protected]>
- updated the copyright
- Added an if condition for delete account and wiper user acount to mark the dialog as open
- Added an action methon to Emitevent to notify UserRow component that an action has been performed

Signed-off-by: JEEEEEEEEEEEEEEEEEEEEEED <[email protected]>
@emoral435
Copy link
Contributor

the title still has "WIP", but you marked this PR as ready to review. Just to check, would you want me to review it now? Only asking because I wouldn't want to comment on things that you did not want me to comment on on :) @jadjoud (p.s. thank you for the PR!)

@jadjoud
Copy link
Contributor Author

jadjoud commented Apr 4, 2024

the title still has "WIP", but you marked this PR as ready to review. Just to check, would you want me to review it now? Only asking because I wouldn't want to comment on things that you did not want me to comment on on :) @jadjoud (p.s. thank you for the PR!)

Yes thank you i forgot to remove the "WIP"

@jadjoud jadjoud changed the title fix issue #44487 (WIP) fix issue #44487 Apr 4, 2024
@jadjoud jadjoud closed this Apr 5, 2024
Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants