-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix issue #44487 #44514
fix issue #44487 #44514
Conversation
…etically We can do this purly in the frontend - but when enforced from the backend using the existing system config, we need to follow the requirement. We then show a warning about the configuration. Signed-off-by: Ferdinand Thiessen <[email protected]> Signed-off-by: JEEEEEEEEEEEEEEEEEEEEEED <[email protected]>
Signed-off-by: Ferdinand Thiessen <[email protected]> Signed-off-by: JEEEEEEEEEEEEEEEEEEEEEED <[email protected]>
Signed-off-by: JEEEEEEEEEEEEEEEEEEEEEED <[email protected]>
Signed-off-by: JEEEEEEEEEEEEEEEEEEEEEED <[email protected]>
- Added an if condition for delete account and wiper user acount to mark the dialog as open - Added an action methon to Emitevent to notify UserRow component that an action has been performed Signed-off-by: JEEEEEEEEEEEEEEEEEEEEEED <[email protected]>
- updated the copyright - Added an if condition for delete account and wiper user acount to mark the dialog as open - Added an action methon to Emitevent to notify UserRow component that an action has been performed Signed-off-by: JEEEEEEEEEEEEEEEEEEEEEED <[email protected]>
the title still has "WIP", but you marked this PR as ready to review. Just to check, would you want me to review it now? Only asking because I wouldn't want to comment on things that you did not want me to comment on on :) @jadjoud (p.s. thank you for the PR!) |
Yes thank you i forgot to remove the "WIP" |
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! |
Summary
The "Delete account" dialog opens on top of each other
TODO
Checklist