Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Allow using replica config with split databases #44470

Merged
merged 1 commit into from
Mar 26, 2024

Conversation

juliusknorr
Copy link
Member

@juliusknorr juliusknorr commented Mar 26, 2024

Otherwise using Replication with Splitting databases would be incompatible as the split database would pick up the replica of the regular database.

With this change there is also the possibility to configure dedicated replicas for each config prefix of a database.

@juliusknorr juliusknorr added bug 3. to review Waiting for reviews labels Mar 26, 2024
@juliusknorr juliusknorr requested review from nickvergessen, ChristophWurst, a team, ArtificialOwl, nfebe and sorbaugh and removed request for a team March 26, 2024 08:29
@juliusknorr juliusknorr added this to the Nextcloud 29 milestone Mar 26, 2024
@juliusknorr
Copy link
Member Author

/backport to stable28

@ChristophWurst ChristophWurst added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Mar 26, 2024
@Altahrim Altahrim mentioned this pull request Mar 26, 2024
@schiessle
Copy link
Member

can we than also update the documentation with a example? Thanks a lot!

@juliusknorr juliusknorr added the pending documentation This pull request needs an associated documentation update label Mar 26, 2024
@juliusknorr juliusknorr self-assigned this Mar 26, 2024
@Altahrim Altahrim merged commit b304dc7 into master Mar 26, 2024
167 checks passed
@Altahrim Altahrim deleted the fix/compatibility-replica-splitting branch March 26, 2024 19:27
Copy link

backportbot bot commented Mar 26, 2024

The backport to stable28 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable28
git pull origin stable28

# Create the new backport branch
git checkout -b backport/44470/stable28

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 2fdb9184

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/44470/stable28

Error: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish bug pending documentation This pull request needs an associated documentation update
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants