Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dav): Fix quota check for chunk upload #44332

Merged
merged 2 commits into from
Apr 2, 2024

Conversation

come-nc
Copy link
Contributor

@come-nc come-nc commented Mar 19, 2024

Summary

Do not ignore header OC-Total-Length when Content-Length and X-Expected-Entity-Length are missing.

Checklist

@come-nc come-nc added the 3. to review Waiting for reviews label Mar 19, 2024
@come-nc come-nc added this to the Nextcloud 29 milestone Mar 19, 2024
@come-nc come-nc requested review from skjnldsv and a team March 19, 2024 16:27
@come-nc come-nc self-assigned this Mar 19, 2024
@come-nc come-nc requested review from ArtificialOwl and nfebe and removed request for a team March 19, 2024 16:27
@Altahrim Altahrim mentioned this pull request Mar 19, 2024
@skjnldsv
Copy link
Member

/backport to stable28

@skjnldsv
Copy link
Member

/backport to stable27

This was referenced Mar 20, 2024
@skjnldsv skjnldsv mentioned this pull request Mar 28, 2024
81 tasks
@come-nc come-nc force-pushed the fix/fix-chunkupload-quota-check branch from 176e853 to d3f2442 Compare April 2, 2024 07:58
@come-nc come-nc modified the milestones: Nextcloud 29, Nextcloud 30 Apr 2, 2024
@come-nc
Copy link
Contributor Author

come-nc commented Apr 2, 2024

/backport to stable29

come-nc added 2 commits April 2, 2024 14:16
Do not ignore OC-Total-Length when Content-Length and
 X-Expected-Entity-Length are missing

Signed-off-by: Côme Chilliet <[email protected]>
@come-nc come-nc force-pushed the fix/fix-chunkupload-quota-check branch from d3f2442 to 01f59be Compare April 2, 2024 12:16
@come-nc come-nc merged commit 9aa7225 into master Apr 2, 2024
168 checks passed
@come-nc come-nc deleted the fix/fix-chunkupload-quota-check branch April 2, 2024 15:44
Copy link

backportbot bot commented Apr 2, 2024

The backport to stable27 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable27
git pull origin stable27

# Create the new backport branch
git checkout -b backport/44332/stable27

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 516fb702 01f59be5

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/44332/stable27

Error: Failed to push branch backport/44332/stable27: fatal: could not read Username for 'https://github.com': No such device or address


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

Copy link

backportbot bot commented Apr 2, 2024

The backport to stable28 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable28
git pull origin stable28

# Create the new backport branch
git checkout -b backport/44332/stable28

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 516fb702 01f59be5

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/44332/stable28

Error: Failed to push branch backport/44332/stable28: fatal: could not read Username for 'https://github.com': No such device or address


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@come-nc
Copy link
Contributor Author

come-nc commented Apr 4, 2024

/backport to stable28

@come-nc
Copy link
Contributor Author

come-nc commented Apr 4, 2024

/backport to stable27

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants