Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Limit email input to 255 chars #44218

Merged
merged 2 commits into from
Mar 21, 2024
Merged

Conversation

nfebe
Copy link
Contributor

@nfebe nfebe commented Mar 15, 2024

Screenshots

A B C
Screenshot from 2024-03-15 18-10-06 Screenshot from 2024-03-16 01-06-51 Screenshot from 2024-03-16 01-07-02

@nfebe nfebe force-pushed the 613-limit-auth-input-emails-255 branch 2 times, most recently from 00a96a9 to 21c61c8 Compare March 15, 2024 11:17
@nickvergessen nickvergessen changed the title WIP: Limit email input on auth pages to 255 chars WIP: Limit email input to 255 chars Mar 15, 2024
@nfebe nfebe force-pushed the 613-limit-auth-input-emails-255 branch 2 times, most recently from 4f9dee4 to b6a0c6a Compare March 16, 2024 00:15
@nfebe nfebe changed the title WIP: Limit email input to 255 chars feat: Limit email input to 255 chars Mar 16, 2024
@nfebe nfebe marked this pull request as ready for review March 16, 2024 00:22
@nfebe nfebe force-pushed the 613-limit-auth-input-emails-255 branch from b6a0c6a to c9ca17d Compare March 16, 2024 00:28
@skjnldsv skjnldsv added bug 2. developing Work in progress labels Mar 16, 2024
@skjnldsv skjnldsv added this to the Nextcloud 29 milestone Mar 16, 2024
@skjnldsv
Copy link
Member

Labels pleaaase :)

@nfebe nfebe self-assigned this Mar 16, 2024
@nfebe nfebe added the 3. to review Waiting for reviews label Mar 16, 2024
@susnux susnux removed the 3. to review Waiting for reviews label Mar 17, 2024
@Altahrim Altahrim mentioned this pull request Mar 18, 2024
@nfebe nfebe force-pushed the 613-limit-auth-input-emails-255 branch from c9ca17d to 301b3d4 Compare March 18, 2024 19:30
return $this->createLoginFailedResponse(
$user,
$user,
$redirect_url,

Check notice

Code scanning / Psalm

PossiblyNullArgument Note

Argument 3 of OC\Core\Controller\LoginController::createLoginFailedResponse cannot be null, possibly null value provided
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe the following or change default on line 317:

Suggested change
$redirect_url,
(string) $redirect_url,

@nfebe nfebe requested a review from susnux March 18, 2024 19:47
@Altahrim Altahrim mentioned this pull request Mar 20, 2024
@nfebe nfebe force-pushed the 613-limit-auth-input-emails-255 branch from 301b3d4 to ada4138 Compare March 20, 2024 15:43
@nfebe nfebe requested a review from Altahrim March 20, 2024 15:43
@nfebe nfebe force-pushed the 613-limit-auth-input-emails-255 branch from ada4138 to 4a80230 Compare March 20, 2024 16:52
@nfebe nfebe requested a review from susnux March 20, 2024 16:52
Excessively long emails reported make server unresponsive.

We could at some point, consider adding a configuration for sysadmins to bypass this setting
on their instance if they want.

Signed-off-by: fenn-cs <[email protected]>
@nfebe nfebe force-pushed the 613-limit-auth-input-emails-255 branch from 4a80230 to 2792d8b Compare March 21, 2024 09:36
@nfebe
Copy link
Contributor Author

nfebe commented Mar 21, 2024

/compile /

Signed-off-by: nextcloud-command <[email protected]>
@nfebe nfebe merged commit c161f0c into master Mar 21, 2024
167 checks passed
@nfebe nfebe deleted the 613-limit-auth-input-emails-255 branch March 21, 2024 14:06
@nfebe
Copy link
Contributor Author

nfebe commented May 13, 2024

/backport to stable29

@nfebe
Copy link
Contributor Author

nfebe commented May 13, 2024

/backport to stable28

@nfebe
Copy link
Contributor Author

nfebe commented May 13, 2024

/backport to stable27

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2. developing Work in progress bug
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants