add contacts popover

[georgehrke]

adds popover as discussed in #207

[MorrisJobke]

adds popover as discussed in #207

And what about #3233?

[MorrisJobke]

cc @ChristophWurst

[georgehrke]

This is the popover you will see when clicking on the avatar / name of the user.
#3233 is about the contacts menu in the upper right corner.

#3233 is ready to review while this is still in development, that's why I created a dedicated PR

[jancborchardt]

@georgehrke there are a bunch of conflicts with master now seemingly, could you resolve them? :)

[jancborchardt]

Tested this in two scenarios where it doesn’t work:

• in the sharing section of the sidebar, clicking a name does nothing
• Same for the Activity app, clicking a name in the stream does nothing.

@georgehrke how to test this?

[georgehrke]

in the sharing section of the sidebar, clicking a name does nothing

That should work, what exactly did you test?

Same for the Activity app, clicking a name in the stream does nothing.

Requires changes in the activity app. Will not be part of this pr

[jancborchardt]

@georgehrke a file shared with another internal user. Should bring up at least info that there is no contact info available, for example. Otherwise it’s confusing. :)

[georgehrke]

[georgehrke]

[georgehrke]

@schiessle Can you test this especially with regard to remote sharing please? :) Thx!

1. works for me. 2. not in scope for this PR

[jancborchardt]

Some drone failures – @georgehrke can you fix them?

cc @nextcloud/javascript @MorrisJobke @schiessle

[georgehrke]

»ERROR: maximum time limit exceeded, build cancelled« is not in my power to fix

[jancborchardt]

Is there a way to restart @MorrisJobke @LukasReschke?

[jospoortvliet]

@georgehrke the other error, though, seems a css thingy: https://drone.nextcloud.com/nextcloud/server/7482/33 an element is not visible. Not sure if that's caused by you but I do notice an issue:


So this user, doglover, has no email set, neither does the other user that has no actions.

It might be that at some point I added an email to doglover and removed it but I'm not sure. Doglover also shows up with an email sign in the contacts menu by @ChristophWurst with no mouse-over (as there is actually no mail address).

[georgehrke]

https://drone.nextcloud.com/nextcloud/server/7482/33

I have absolutely no clue what this test is about. Where is it defined? Can someone point me?

So this user, doglover, has no email set, neither does the other user that has no actions.
It might be that at some point I added an email to doglover and removed it but I'm not sure.

Can you reproduce the same issue in the contacts menu in the top right corner?

[georgehrke]

https://github.com/nextcloud/server/blob/master/tests/acceptance/features/app-files.feature#L31
And I see that a wrong password for the shared file message is shown

I didn't touch any public sharing code. Not sure that's related to my changes

[MorrisJobke]

The drone server is highly overloaded causing the timeouts - let me remove some workers. Regarding the acceptance tests: the problem there is also due to the high load -.-

[georgehrke]

Doglover also shows up with an email sign in the contacts menu by @ChristophWurst with no mouse-over (as there is actually no mail address).

Any clue what causes this @ChristophWurst ?

[jancborchardt]

I think @ChristophWurst is at uni today so we need to fix this without him.

[georgehrke]

I think @ChristophWurst is at uni today so we need to fix this without him.

I haven't been able to tackle the bug so far. As it was introduced with the already merged #3233 and not with this PR I'd vote to fix it in a follow up PR (and potentially beta 2)

[LukasReschke]

I agree with @georgehrke here.

[LukasReschke]

Not a critical bug => Let's get this in.

[jancborchardt]

Looks good! 👍

[jancborchardt]

Who will make the required changes to also make this work in other main shipped apps like:

• Activity @nickvergessen
• Gallery share dialog @oparoz

And sooner or later also:

• Mail @ChristophWurst
• Calendar @georgehrke
• Tasks @raimund-schluessler @Henni

cc @georgehrke would be cool if you can drive that.

[jancborchardt]

I also restarted the tests on Drone.

[LukasReschke]

I also restarted the tests on Drone.

Drone is overloaded. The previous test execution was okay if you ignore the other failing tests. => Let's just merge instead of waiting 10 hours until the Drone backlog is done. Also adding more won't help 🙈

[jancborchardt]

kk :)

[jancborchardt]

Opened a new issue about adding the contacts popover to other apps at #4532 – would be cool if you can push this @georgehrke, especially for Activity and Gallery as they are shipped.

[nickvergessen]

I can add it to activities if sample code is posted somewhere

[georgehrke]

I can add it to activities if sample code is posted somewhere

I will send a pr tomorrow :)

[nickvergessen]

Please also create a topic in https://help.nextcloud.com/c/dev/ so app devs get notified

[ChristophWurst]

I can add it to activities if sample code is posted somewhere

nextcloud/contacts#173 and https://github.com/ChristophWurst/contactsmenu_social

[ChristophWurst]

Ah, you mean the popover I guess. Nvm then …