-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[stable27] fix(share): use user timezone to parse share expiration date #42791
Conversation
If an user in UTC+1 try to create a share at 00:00, it's day D for him, but D-1 for the server (UTC). This fix aims to apply the correct offset Signed-off-by: Benjamin Gaussorgues <[email protected]>
2ffc266
to
ee6a10f
Compare
/backport to stable26 |
Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22 |
The backport to stable26 failed. Please do this backport manually. # Switch to the target branch and update it
git checkout stable26
git pull origin stable26
# Create the new backport branch
git checkout -b fix/foo-stable26
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123
# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable26 Error: Unknown error More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport |
/skjnldsv-backport to stable26 |
The backport to # Switch to the target branch and update it
git checkout stable26
git pull origin stable26
# Create the new backport branch
git checkout -b backport/42791/stable26
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick ee6a10f8f53cae62bfa6c88a42d731864b73c54f
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/42791/stable26 Error: Validation Failed: {"resource":"PullRequest","code":"custom","message":"No commits between stable26 and backport/42791/stable26"} Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
Backport of #42660
Warning, This backport's changes differ from the original and might be incomplete⚠️
Todo
[skip ci]
tagLearn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.