[stable27] fix(Users/Quota setting): Prevent floating point value from getting truncated in locales other than english

[marcelklehr]

• Resolves: Cannot set user quota with uneven values using locales that use a comma as decimal separator #18468

Checklist

• Code is properly formatted
• Sign-off message is added to all commits
• Tests (unit, integration, api and/or acceptance) are included
• Screenshots before/after for front-end changes
• Documentation (manuals or wiki) has been updated or is not required
• Backports requested where applicable (ex: critical bugfixes)

[marcelklehr]

/compile

[marcelklehr]

/compile

[marcelklehr]

/backport fced4c9 to stable26

[Pytal]

In future let's not add unrelated changes in backports @marcelklehr ;)

[blizzz]

new conflicts

[marcelklehr]

/compile

[marcelklehr]

/backport f0d8dbd to stable26

[marcelklehr]

/compile

[marcelklehr]

/compile

[blizzz]

Binary files a/dist/6799-6799.js and /dev/null differ

I have questions 😅

[blizzz]

CI is not satisfied

[marcelklehr]

/compile

[marcelklehr]

Cypress failure seems to be unrelated

[backportbot-nextcloud]

The backport to stable26 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable26
git pull origin stable26

# Create the new backport branch
git checkout -b fix/foo-stable26

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable26

Error: Unknown error

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

[marcelklehr]

/skjnldsv-backport fa2cf8d to stable26

[skjnldsv]

@marcelklehr there are HUGE breaking changes between 3.0 beta and final. This is why we never upgrade for old versions. This change broke 27.1.6.

I would have been asked for review, this PR would have been blocked imho.
The great amount of changes in the dist folder is not a proof of a stable fix for an old stable branch. Please avoid this in the future 🙏

[marcelklehr]

I'm sorry for breaking v27.1.6. I only do what I think is reasonable, obviously, so I cannot promise to avoid something like this in the future. As you say, this should have been caught in the review process. Since it hasn't been, maybe the process is flawed.

[skjnldsv]

Not promising to not create bugs is perfectly fine, I did a good one for 28 last week too 😁
I was mostly referring to breaking-change upgrades for old stable branches 😉

[marcelklehr]

Can we revert just the package.json change? I'm afraid I will mess up the package-lock.json

[skjnldsv]

Can we revert just the package.json change? I'm afraid I will mess up the package-lock.json

We need to discuss this with @susnux, because other areas might be broken 🤔

[susnux]

There are some behavior changes in @nextcloud/files between that beta and the stable change, so it might be that currently some filepicker stuff is broken. If we not revert then maybe just update the nextcloud/dialogs 4.x branch to also be compatible with files v3

[marcelklehr]

I think we should revert to nextcloud/files beta if that's how it was supposed to be in 27. I was mostly concerned about the other changes in this PR, as they are fixing a bug.