Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(settings): add occ commands to handle admin delegation #42064

Merged
merged 1 commit into from
Dec 13, 2023

Conversation

Altahrim
Copy link
Collaborator

@Altahrim Altahrim commented Dec 6, 2023

Summary

Add commands to handle admin delegation settings:

  • settings:admin-delegation:show: show current delegation
  • settings:admin-delegation:add: add a delegation to a group
  • settings:admin-delegation:remove: remove a delegation from a group

Checklist

@Altahrim Altahrim requested a review from a team December 6, 2023 15:21
@Altahrim Altahrim self-assigned this Dec 6, 2023
@Altahrim Altahrim requested review from a team, ArtificialOwl, icewind1991 and sorbaugh and removed request for a team December 6, 2023 16:13
apps/settings/lib/Command/AdminDelegation/Add.php Outdated Show resolved Hide resolved
apps/settings/lib/Command/AdminDelegation/Remove.php Outdated Show resolved Hide resolved
apps/settings/lib/Command/AdminDelegation/Show.php Outdated Show resolved Hide resolved
apps/settings/lib/Command/AdminDelegation/Add.php Outdated Show resolved Hide resolved
apps/settings/lib/Command/AdminDelegation/Remove.php Outdated Show resolved Hide resolved
apps/settings/lib/Command/AdminDelegation/Show.php Outdated Show resolved Hide resolved
@Altahrim Altahrim force-pushed the feat/settings/add-delegation-commands branch from d04bae7 to 0bef261 Compare December 7, 2023 14:17
@Altahrim Altahrim requested review from artonge, Pytal and come-nc December 7, 2023 14:17
Copy link
Contributor

@come-nc come-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works

@blizzz blizzz added this to the Nextcloud 29 milestone Dec 12, 2023
@Altahrim Altahrim force-pushed the feat/settings/add-delegation-commands branch from 0bef261 to 208e6bc Compare December 13, 2023 08:25
@Altahrim Altahrim added the pending documentation This pull request needs an associated documentation update label Dec 13, 2023
@Altahrim Altahrim enabled auto-merge December 13, 2023 08:30
@Altahrim Altahrim merged commit 6077f26 into master Dec 13, 2023
50 checks passed
@Altahrim Altahrim deleted the feat/settings/add-delegation-commands branch December 13, 2023 09:06
@Altahrim
Copy link
Collaborator Author

/backport to stable28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: settings pending documentation This pull request needs an associated documentation update
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants