-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(settings): add occ commands to handle admin delegation #42064
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Altahrim
requested review from
a team,
ArtificialOwl,
icewind1991 and
sorbaugh
and removed request for
a team
December 6, 2023 16:13
artonge
requested changes
Dec 6, 2023
Pytal
reviewed
Dec 6, 2023
come-nc
reviewed
Dec 7, 2023
Altahrim
force-pushed
the
feat/settings/add-delegation-commands
branch
from
December 7, 2023 14:17
d04bae7
to
0bef261
Compare
come-nc
approved these changes
Dec 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and works
Pytal
approved these changes
Dec 7, 2023
artonge
approved these changes
Dec 12, 2023
Signed-off-by: Benjamin Gaussorgues <[email protected]>
Altahrim
force-pushed
the
feat/settings/add-delegation-commands
branch
from
December 13, 2023 08:25
0bef261
to
208e6bc
Compare
Altahrim
added
the
pending documentation
This pull request needs an associated documentation update
label
Dec 13, 2023
/backport to stable28 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add commands to handle admin delegation settings:
settings:admin-delegation:show
: show current delegationsettings:admin-delegation:add
: add a delegation to a groupsettings:admin-delegation:remove
: remove a delegation from a groupChecklist