New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Users/Quota setting): Prevent floating point value from getting truncated in locales other than english #42053

Merged

marcelklehr merged 2 commits into master from fix/18468

Dec 7, 2023

Member

marcelklehr commented Dec 6, 2023

Resolves: Cannot set user quota with uneven values using locales that use a comma as decimal separator #18468

Checklist

Code is properly formatted
Sign-off message is added to all commits
Tests (unit, integration, api and/or acceptance) are included
Screenshots before/after for front-end changes
Documentation (manuals or wiki) has been updated or is not required
Backports requested where applicable (ex: critical bugfixes)

marcelklehr requested review from skjnldsv and Pytal

December 6, 2023 13:10

backportbot-nextcloud bot added the backport-request label

marcelklehr force-pushed the fix/18468 branch from 4667336 to 5ebcc6d Compare

December 6, 2023 13:43

skjnldsv approved these changes

View reviewed changes

Pytal approved these changes

View reviewed changes

Member Author

marcelklehr commented Dec 6, 2023

/backport 5ebcc6d to stable28

Member Author

marcelklehr commented Dec 6, 2023

/backport 5ebcc6d to stable27

Member Author

marcelklehr commented Dec 6, 2023

/backport 5ebcc6d to stable26

Member Author

marcelklehr commented Dec 6, 2023

/compile

marcelklehr enabled auto-merge

December 6, 2023 19:05

marcelklehr force-pushed the fix/18468 branch from 2f05163 to 5ebcc6d Compare

December 7, 2023 08:56


          fix(Users/Quota setting): Prevent floating point value from getting t…

162f801

…runcated in locales other than english

fixes #18468

Signed-off-by: Marcel Klehr <[email protected]>

marcelklehr force-pushed the fix/18468 branch from 5ebcc6d to 162f801 Compare

December 7, 2023 08:57

Member Author

marcelklehr commented Dec 7, 2023

/compile

1 similar comment

Member Author

marcelklehr commented Dec 7, 2023

/compile


          chore(assets): Recompile assets

0f667d2

Signed-off-by: nextcloud-command <[email protected]>

skjnldsv reviewed

View reviewed changes

apps/settings/src/components/Users/UserRow.vue

@@ @@ -307,6 +307,7 @@ import UserRowActions from './UserRowActions.vue' @@
               import UserRowMixin from '../../mixins/UserRowMixin.js'
               import { isObfuscated, unlimitedQuota } from '../../utils/userUtils.ts'
+              import {formatFileSize, parseFileSize} from "@nextcloud/files";

Member

skjnldsv Dec 7, 2023 •

edited

Loading

Suggested change

      
            import {formatFileSize, parseFileSize} from "@nextcloud/files";
          
            import { formatFileSize, parseFileSize } from '@nextcloud/files'

marcelklehr merged commit 7b6877b into master

41 checks passed

marcelklehr deleted the fix/18468 branch

December 7, 2023 13:21

Member Author

marcelklehr commented Dec 7, 2023

/backport 162f801 to stable28

Member Author

marcelklehr commented Dec 7, 2023

/backport 162f801 to stable27

Member Author

marcelklehr commented Dec 7, 2023

/backport 162f801 to stable26

Member Author

marcelklehr commented Dec 7, 2023

/backport 162f801 to stable28

backportbot-nextcloud bot mentioned this pull request

[stable28] fix(Users/Quota setting): Prevent floating point value from getting truncated in locales other than english #42106

Merged

backportbot-nextcloud bot removed the backport-request label

Member Author

marcelklehr commented Dec 7, 2023 •

edited

Loading

/backport 162f801 to stable27

Member Author

marcelklehr commented Dec 7, 2023

/backport 162f801 to stable27

backportbot-nextcloud bot added the backport-request label

Member Author

marcelklehr commented Dec 7, 2023

/backport 162f801 to stable26

Member Author

marcelklehr commented Dec 7, 2023

/backport 162f801 to stable27

Member Author

marcelklehr commented Dec 12, 2023

/backport 162f801 to stable27

skjnldsv mentioned this pull request

fix(settings): set default or unlimited user quota #42723

Merged

blizzz added this to the Nextcloud 28 milestone

blizzz mentioned this pull request

29.0.0 beta 1 #43991

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-request