fix(files): Sort list ASC by default #41485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickvergessen
added
bug
3. to review
ShGKme
approved these changes
Nov 15, 2023
artonge
approved these changes
Nov 15, 2023
susnux
reviewed
Nov 16, 2023
| @@ -47,7 +47,7 @@ export default Vue.extend({ | |||
| */ | |||
| isAscSorting(): boolean { | |||
| const sortingDirection = this.getConfig(this.currentView.id)?.sorting_direction | |||
There was a problem hiding this comment.
Or like this
Suggested change
| const sortingDirection = this.getConfig(this.currentView.id)?.sorting_direction | |
| const sortingDirection = this.getConfig(this.currentView.id)?.sorting_direction ?? 'asc' |
susnux
approved these changes
Nov 16, 2023
Signed-off-by: Joas Schilling <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
Rebasing |
nickvergessen
force-pushed
the
bugfix/noid/sort-asc-by-default
branch
from
3e46e6d to
9a9cdce
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
undefineddid not matchascis it toggled the order.Checklist