Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(files): Sort list ASC by default #41485

Merged
merged 2 commits into from
Nov 16, 2023

Conversation

nickvergessen
Copy link
Member

  • Resolves: #

Summary

  • After installing the Nextcloud (or deleting the preference entry) the files list was sorted DESC by accident. The problem is that undefined did not match asc is it toggled the order.

Checklist

@@ -47,7 +47,7 @@ export default Vue.extend({
*/
isAscSorting(): boolean {
const sortingDirection = this.getConfig(this.currentView.id)?.sorting_direction
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or like this

Suggested change
const sortingDirection = this.getConfig(this.currentView.id)?.sorting_direction
const sortingDirection = this.getConfig(this.currentView.id)?.sorting_direction ?? 'asc'

@nickvergessen
Copy link
Member Author

Conflicting files
dist/files-main.js
dist/files-main.js.map

Rebasing

@nickvergessen nickvergessen force-pushed the bugfix/noid/sort-asc-by-default branch from 3e46e6d to 9a9cdce Compare November 16, 2023 05:20
@nickvergessen nickvergessen merged commit 04c3fea into master Nov 16, 2023
@nickvergessen nickvergessen deleted the bugfix/noid/sort-asc-by-default branch November 16, 2023 09:35
@blizzz blizzz mentioned this pull request Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants