Enhancements : improve most recent global search UI

[nfebe]

• Fixes remove person filter/chip when applied
• Close person searchable filter via workaround

Resolves : #41381

TODO

• Icon inversion which does not work well now since icons come in white or black instead of one consistent color. (Black icons turn white and white icons turn black, leading to to white on white background issues)
• Use the new people filter (selector) that @marcoambrosini is working on (Current people filter not completed) - DONE, however, NcPopover which is used has issues with closing triggers.
• Update back-end API (if ability not already present) to show "Search in App" dynamically.
• Remove person filter not possible

From @ChristophWurst

• BUG: Clicking outside the search modal needs two clicks on the magnifier icon to get the modal back.
• BUG: Some app icons are white on white.
• BUG: Modified timestamp bubbles change size on hover, have no pointing cursor.
• BUG: Generally no feedback for no results.
• BUG: Search people has white text on white background.
• BUG: Search people has a tiny user bubble, barely wider than the avatar.
• BUG: Search people No result goes to the top, overlaps other input.
• BUG: Search people has no effect at all. The search string doesn't contain a person identifier.

[marcoambrosini]

Design review notes

High

• Icons updated in the backend (Fix search providers icons #41432)
• Icons shouldn’t be white in filter tags (in regular theme) (Fix default icon: should be white instead of black #41412, Fix search providers icons #41432)
• Mail previews not right
• Broken folder icon in files results
• Messages: avatar in circles not squares
• Add empty content when no results (also clear search button)
• Apps (category) need to be deprioritized in search results (Fix apps search provider order #41413)
• “Search in app” is only available for a few apps (remove links)

Medium

• Contacts filter shouldn’t be available if contacts app is not available
• No space for icons in modified
• filter buttons justified to the left
• Close icon shouldn't be jumping on hover

Low

• Empty content vertically centered
• Apply range primary to the right
• Date range filter -> custom date range
• Apply range -> Search in date range
• 4px gap between all the elements in the input, filters, tags
• Text in people regular not bold
• Close icon material design icon "close" instead of "close-thick"
• Cursor pointer instead on hovering close icon
• Avatar in filter chips shouldn't be clickable and size should be 24px

[Altahrim]

Performance

• /providers should be called only when user interact with the search, not on every page load

UI

• "Modified" button should be renamed as we are not always searching on a modification date

[AndyScherzinger]

can't judge, but 👍 for merging the improvements for beta3 build

[nfebe]

FYI : @blizzz and others, open items on this ticket would be moved to the a new PR and issue would open (or re-opened).

For beta3 merge considerations

[nfebe]

/compile amend /

[nfebe]

/compile amend /