-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove comments tab from files #41201
Conversation
Setting
pending documentation
|
Thanks for pointing it out! For context, the comments feature is being moved to the activity repo, so this is one of two pull requests. |
eebbf87
to
224e8eb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this file still needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What was the use of this file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, most of this need to be kept as:
if activity app is disabled and comments app enabled:
show comments tab as-is
That also means we can keep the public API working for apps using the comments UI, that's great news! |
closing in favor of #41491 |
Summary
This is the the second part of a two part Pull Request to move code from the comments app found in server to the activity app.
Here is the other PR: nextcloud/activity#1387
Checklist