-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add custom apps translation scripts and image path for consistency #40898
Add custom apps translation scripts and image path for consistency #40898
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm unsure about this change in general.
I have plenty of apps in apps-extra and see the requests for the translation files.
For me, Ah I recall now it is set through the |
@juliushaertl @skjnldsv I'm totally unsure if the patch makes sense, we need it, etc .. 🙈 However, I dislike the ability to modify files from apps via a theme. |
94a02b6
to
e30c3de
Compare
I'm all in for dropping the theme generally once we have proper ways to achieve its mainly used functionality otherwise #27433 I think for now the change makes sense, to ensure that the legacy theme mechanism works as expected with custom app paths. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be good to squash the commits into one, otherwise this seems good.
Signed-off-by: Akhil <[email protected]>
e30c3de
to
5e20c3e
Compare
@juliushaertl Squashed |
Failures seem unrelated. |
Summary
Checklist