Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(federation): Use sharing.federation.allowSelfSignedCertificates config for all OCM requests #40864

Conversation

nickvergessen
Copy link
Member

Summary

The config already existed in many places, but was missed in these two, breaking it, because federation requests actually didn't work for self-signed certificates:

Checklist

… config for all OCM requests

Signed-off-by: Joas Schilling <[email protected]>
Copy link
Member

@mejo- mejo- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good apart from my comment.

Signed-off-by: Joas Schilling <[email protected]>
@nickvergessen nickvergessen merged commit dd0142f into master Oct 12, 2023
38 checks passed
@nickvergessen nickvergessen deleted the bugfix/noid/use-allowSelfSignedCertificates-for-all-OCM-requests branch October 12, 2023 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants