Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adding the displayname to the output of occ group:list --info #40427

Merged
merged 1 commit into from
Aug 6, 2024

Conversation

ThibautPlg
Copy link
Contributor

Adding the displayname to the output of occ group:list --info command

  • Resolves: no bugs related

Summary

When using occ group:list --info, the displayName is not returned. I then need to make a new occ group:info groupId for every group to have a full and usable list.
This PR simply adds the displayName info to the info output.

Before :

# [...]occ group:list --info 
[...]

  - mygroup:
    - backends:
      - Database
    - users:
      - thibautplg

After :

# [...]occ group:list --info 
[...]

  - mygroup:
    - displayName: My Nextcloud group
    - backends:
      - Database
    - users:
      - thibautplg

Checklist

@szaimen szaimen added the 3. to review Waiting for reviews label Sep 14, 2023
@szaimen szaimen added this to the Nextcloud 28 milestone Sep 14, 2023
@szaimen szaimen requested review from a team, ArtificialOwl, icewind1991 and sorbaugh and removed request for a team September 14, 2023 13:47
@skjnldsv skjnldsv mentioned this pull request Nov 1, 2023
This was referenced Nov 6, 2023
This was referenced Nov 14, 2023
@blizzz blizzz modified the milestones: Nextcloud 28, Nextcloud 29 Nov 23, 2023
This was referenced Mar 12, 2024
@Altahrim
Copy link
Collaborator

@ThibautPlg Can you rebase and reword your commit using conventional commit please?

@ThibautPlg ThibautPlg changed the title Adding the displayname to the output of occ group:list --info feat: Adding the displayname to the output of occ group:list --info Mar 15, 2024
@ThibautPlg
Copy link
Contributor Author

@ThibautPlg Can you rebase and reword your commit using conventional commit please?

Not sure if I merged the correct way. Can the conventional commit rules be specified on the generic contribution checklist?
Regards,

@Altahrim
Copy link
Collaborator

@ThibautPlg You changed the title of the pull request but you have to rename the commit itself

As you have a merge commit, you should be able to use the following commands:

git pull
git rebase -i origin/master --sign-off
# Here, drop the merge commit and reword the other commit
git push --force-with-lease

@Altahrim Altahrim mentioned this pull request Mar 18, 2024
auto-merge was automatically disabled March 19, 2024 15:39

Head branch was pushed to by a user without write access

@ThibautPlg
Copy link
Contributor Author

Reverting because I noticed wrongly merged files in the last merge commit.

@blizzz blizzz added this to the Nextcloud 30 milestone Apr 8, 2024
@skjnldsv skjnldsv added 2. developing Work in progress stale Ticket or PR with no recent activity and removed 3. to review Waiting for reviews labels Jul 27, 2024
This was referenced Jul 30, 2024
@Jerome-Herbinet Jerome-Herbinet added 3. to review Waiting for reviews feature: users and groups and removed 2. developing Work in progress labels Aug 2, 2024
@Altahrim Altahrim mentioned this pull request Aug 5, 2024
@AndyScherzinger AndyScherzinger force-pushed the master branch 2 times, most recently from 5559edf to 118ab3e Compare August 6, 2024 12:01
@AndyScherzinger
Copy link
Member

I fixed the commit message for your convenience @ThibautPlg

so @sorbaugh @icewind1991 @Altahrim can you re-review please and merge if fine with you?

@Altahrim Altahrim added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Aug 6, 2024
@ThibautPlg
Copy link
Contributor Author

I fixed the commit message for your convenience @ThibautPlg

so @sorbaugh @icewind1991 @Altahrim can you re-review please and merge if fine with you?

If something was awaiting my input I didn't noticed.
Thanks you

…list --info` command

Signed-off-by: ThibautPlg <[email protected]>
Signed-off-by: Andy Scherzinger <[email protected]>
@AndyScherzinger AndyScherzinger merged commit 3c4ee71 into nextcloud:master Aug 6, 2024
154 of 161 checks passed
Copy link

welcome bot commented Aug 6, 2024

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22

@AndyScherzinger
Copy link
Member

Thanks @ThibautPlg - merged it now. All seemed fine and all reviews are there. Some test won't be run on forks, so let's see if they still turn green on the merged master branch 👍

Sorry for the time it took to get it in but happy that we managed to do so in the end 🚀

@juliusknorr
Copy link
Member

CI was failing, pushed adjusted unit tests to #47083

@AndyScherzinger
Copy link
Member

Thanks a lot @juliushaertl

@Altahrim Altahrim mentioned this pull request Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish feature: occ feature: users and groups stale Ticket or PR with no recent activity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants