-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Adding the displayname to the output of occ group:list --info #40427
Conversation
f6684a3
to
e6bbaad
Compare
@ThibautPlg Can you rebase and reword your commit using conventional commit please? |
Not sure if I merged the correct way. Can the conventional commit rules be specified on the generic contribution checklist? |
@ThibautPlg You changed the title of the pull request but you have to rename the commit itself As you have a merge commit, you should be able to use the following commands:
|
Head branch was pushed to by a user without write access
Reverting because I noticed wrongly merged files in the last merge commit. |
5559edf
to
118ab3e
Compare
I fixed the commit message for your convenience @ThibautPlg so @sorbaugh @icewind1991 @Altahrim can you re-review please and merge if fine with you? |
If something was awaiting my input I didn't noticed. |
…list --info` command Signed-off-by: ThibautPlg <[email protected]> Signed-off-by: Andy Scherzinger <[email protected]>
Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22 |
Thanks @ThibautPlg - merged it now. All seemed fine and all reviews are there. Some test won't be run on forks, so let's see if they still turn green on the merged master branch 👍 Sorry for the time it took to get it in but happy that we managed to do so in the end 🚀 |
CI was failing, pushed adjusted unit tests to #47083 |
Thanks a lot @juliushaertl |
Adding the displayname to the output of occ group:list --info command
Summary
When using
occ group:list --info
, the displayName is not returned. I then need to make a newocc group:info groupId
for every group to have a full and usable list.This PR simply adds the
displayName
info to the info output.Before :
After :
Checklist