-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display user status by the side in sharing flow #40393
Conversation
The quick share drop down now takes the place where the user status would show in the past, so we have the option of removing it (as it's available in the profile dropdown) or putting it at the side as such. It's put on the side without the icon, as the status icon appears on the avatar when set. Signed-off-by: fenn-cs <[email protected]>
32c4c01
to
c0344a2
Compare
c0344a2
to
7d9b5b6
Compare
Removes button from footer and removes button background. Signed-off-by: fenn-cs <[email protected]>
Looks good, just some minor issues as mentioned partially already
|
7d9b5b6
to
2b2622d
Compare
So no wrap? things wrap in a decent way when text is too long as shown in the last screen shots.
cc: @AndyScherzinger |
Sorry but with wrapping it looks way too wonky, we shouldn't do that. It needs to be ellipsized to one line. :) Also, the gap between the first line and the permission line is too big for users. For "Share link" it looks good, but for the users below it's larger. |
@fenn-cs Color value in use looks good 👍 |
/backport to stable27 |
The backport to stable27 failed. Please do this backport manually. # Switch to the target branch and update it
git checkout stable27
git pull origin stable27
# Create the new backport branch
git checkout -b fix/foo-stable27
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123
# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable27 More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport |
The quick share drop down now takes the place where the user status would show in the past, so we have the option of removing it (as it's available in the profile dropdown) or putting it at the side as such.
It's put on the side without the icon, as the status icon appears on the avatar when set.