40172 polish sharing flow bugs #40372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nfebe
force-pushed
the
40172-polish-sharing-flow-bugs
branch
from
3b503bd to
0e4e782
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
nfebe
force-pushed
the
40172-polish-sharing-flow-bugs
branch
from
f8d28a6 to
71f88e0
Compare
nfebe
requested review from
AndyScherzinger,
juliusknorr,
artonge and
Pytal
AndyScherzinger
approved these changes
Sep 12, 2023
juliusknorr
reviewed
Sep 12, 2023
artonge
approved these changes
Sep 12, 2023
nfebe
force-pushed
the
40172-polish-sharing-flow-bugs
branch
from
71f88e0 to
9ff9390
Compare
nfebe
force-pushed
the
40172-polish-sharing-flow-bugs
branch
2 times, most recently
from
0ed74d6 to
d5fce36
Compare
Signed-off-by: fenn-cs <[email protected]>
Use the the modern intial-state library to pass data about `allowPublicUploads` to the sharing frontend. Signed-off-by: fenn-cs <[email protected]>
nfebe
force-pushed
the
40172-polish-sharing-flow-bugs
branch
from
d5fce36 to
71b6d47
Compare
|
/compile amend / |
Delete button text should have same size as other buttons. Signed-off-by: fenn-cs <[email protected]> Signed-off-by: nextcloud-command <[email protected]>
nextcloud-command
force-pushed
the
40172-polish-sharing-flow-bugs
branch
from
5166f51 to
3d071ab
Compare
|
/backport to stable27 |
|
The backport to stable27 failed. Please do this backport manually. # Switch to the target branch and update it
git checkout stable27
git pull origin stable27
# Create the new backport branch
git checkout -b fix/foo-stable27
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123
# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable27More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport |
1 similar comment
|
The backport to stable27 failed. Please do this backport manually. # Switch to the target branch and update it
git checkout stable27
git pull origin stable27
# Create the new backport branch
git checkout -b fix/foo-stable27
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123
# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable27More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves : #40172