Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(CalDAV): check birthday calendar owner #40292

Merged
merged 1 commit into from
Sep 6, 2023
Merged

Conversation

miaulalala
Copy link
Contributor

@miaulalala miaulalala commented Sep 6, 2023

Summary

Add the correct 403 response for the DAV endpoint

Checklist

@miaulalala miaulalala added bug 3. to review Waiting for reviews labels Sep 6, 2023
@miaulalala miaulalala self-assigned this Sep 6, 2023
@miaulalala
Copy link
Contributor Author

/backport to stable27

@miaulalala
Copy link
Contributor Author

/backport to stable26

@miaulalala
Copy link
Contributor Author

/backport to stable25

@miaulalala miaulalala force-pushed the fix/birthday-calendar branch from 918d9b1 to aa19033 Compare September 6, 2023 12:50
@miaulalala
Copy link
Contributor Author

/backport to stable24

@miaulalala
Copy link
Contributor Author

/backport to stable23

@@ -327,7 +327,8 @@
}
$this->server->addPlugin(new \OCA\DAV\CalDAV\BirthdayCalendar\EnablePlugin(
\OC::$server->getConfig(),
\OC::$server->query(BirthdayService::class)
\OC::$server->query(BirthdayService::class),

Check notice

Code scanning / Psalm

DeprecatedMethod

The method OC\ServerContainer::query has been marked as deprecated
@miaulalala
Copy link
Contributor Author

/backport to stable22

@miaulalala

This comment was marked as resolved.

Copy link
Member

@tcitworld tcitworld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, but shouldn't the CalendarHome's owner be the only one to be able to POST on it anyway?

Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense

@joshtrichards joshtrichards added the feature: caldav Related to CalDAV internals label Sep 6, 2023
@backportbot-nextcloud

This comment was marked as resolved.

@backportbot-nextcloud

This comment was marked as resolved.

@backportbot-nextcloud

This comment was marked as resolved.

@backportbot-nextcloud

This comment was marked as resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews backport-request bug feature: caldav Related to CalDAV internals
Projects
Development

Successfully merging this pull request may close these issues.

8 participants