Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor OC\Server::getL10NFactory #40141

Merged

Conversation

summersab
Copy link
Contributor

This PR refactors the deprecated method OC\Server::getL10NFactory and replaces it with OC\Server::get(\OCP\L10N\IFactory::class) throughout the entire NC codebase (excluding ./apps and ./3rdparty).

Additionally, where necessary, the \OCP\L10N\IFactory class is imported via the use directive.

@summersab summersab force-pushed the refactor/OC-Server-getL10NFactory branch from b2b6d3c to f80282a Compare August 30, 2023 02:30
@solracsf solracsf added the 3. to review Waiting for reviews label Aug 30, 2023
@solracsf solracsf added this to the Nextcloud 28 milestone Aug 30, 2023
@skjnldsv skjnldsv mentioned this pull request Nov 1, 2023
This was referenced Nov 6, 2023
This was referenced Nov 14, 2023
@blizzz blizzz modified the milestones: Nextcloud 28, Nextcloud 29 Nov 23, 2023
This was referenced Mar 12, 2024
@Altahrim
Copy link
Collaborator

@summersab Can you fix the conflicts please?

This was referenced Mar 20, 2024
@skjnldsv skjnldsv mentioned this pull request Mar 28, 2024
81 tasks
@skjnldsv skjnldsv modified the milestones: Nextcloud 29, Nextcloud 30 Mar 28, 2024
@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels May 30, 2024
@skjnldsv skjnldsv enabled auto-merge May 30, 2024 12:20
@skjnldsv skjnldsv disabled auto-merge May 30, 2024 15:51
@skjnldsv skjnldsv merged commit 5866e49 into nextcloud:master May 30, 2024
139 of 146 checks passed
@blizzz blizzz mentioned this pull request Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish technical debt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants