Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enh(settings): Add and remove groups accessibly #40110

Merged
merged 4 commits into from
Oct 11, 2023
Merged

Conversation

Pytal
Copy link
Member

@Pytal Pytal commented Aug 30, 2023

Summary

Before After
image image
image image

TODO

  • Tests

Checklist

marcoambrosini

This comment was marked as resolved.

@Pytal Pytal force-pushed the enh/a11y/add-group branch from 1126756 to 9f913ed Compare August 30, 2023 18:02
@Pytal
Copy link
Member Author

Pytal commented Aug 30, 2023

@Pytal I would still prefer to have a heading in the menu that states what's the current operation that the user is undergoing, similar to contacts.

Something like heading of the tooltip "Create group" Label of the input: "Group name"

Done!

Also moved the actions next to the "Groups" navigation caption

Copy link
Contributor

@ShGKme ShGKme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works and looks good. But we should avoid using $children when possible.

apps/settings/src/views/Users.vue Outdated Show resolved Hide resolved
apps/settings/src/views/Users.vue Show resolved Hide resolved
@Pytal Pytal force-pushed the enh/a11y/add-group branch from 9f913ed to 847f038 Compare August 31, 2023 23:53
@Pytal Pytal marked this pull request as draft September 1, 2023 00:01
@Pytal Pytal force-pushed the enh/a11y/add-group branch from 847f038 to d09982e Compare September 13, 2023 00:45
@Pytal Pytal force-pushed the enh/a11y/add-group branch from d09982e to 630356b Compare October 7, 2023 00:36
apps/settings/src/views/Users.vue Outdated Show resolved Hide resolved
apps/settings/src/views/Users.vue Outdated Show resolved Hide resolved
apps/settings/src/views/Users.vue Outdated Show resolved Hide resolved
@Pytal Pytal force-pushed the enh/a11y/add-group branch from 630356b to 9e731d0 Compare October 11, 2023 00:13
@Pytal Pytal changed the base branch from master to fix/app-nav-caption October 11, 2023 00:14
@Pytal Pytal marked this pull request as ready for review October 11, 2023 00:21
@Pytal Pytal changed the title enh(settings): Add groups accessibly enh(settings): Add and remove groups accessibly Oct 11, 2023
@Pytal Pytal force-pushed the enh/a11y/add-group branch 2 times, most recently from aaf6beb to 1965acb Compare October 11, 2023 00:36
@Pytal Pytal requested a review from marcoambrosini October 11, 2023 00:42
Base automatically changed from fix/app-nav-caption to master October 11, 2023 16:46
@Pytal Pytal force-pushed the enh/a11y/add-group branch from 1965acb to 4386803 Compare October 11, 2023 17:48
@Pytal Pytal added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Oct 11, 2023
@Pytal Pytal merged commit 228b21f into master Oct 11, 2023
@Pytal Pytal deleted the enh/a11y/add-group branch October 11, 2023 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish accessibility feature: users and groups
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants