fix(updatecheck): Don't wait 120s for a response of updater.nextcloud… #40071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickvergessen
added
3. to review
SystemKeeper
approved these changes
Aug 28, 2023
solracsf
approved these changes
Aug 28, 2023
kesselb
approved these changes
Aug 28, 2023
kesselb
added
4. to release
|
/backport to stable27 |
susnux
force-pushed
the
bugfix/noid/dont-block-admin-page-when-updater.nextcloud.com-is-down
branch
from
caf4096 to
23eda68
Compare
Merged
….com Signed-off-by: Joas Schilling <[email protected]>
blizzz
force-pushed
the
bugfix/noid/dont-block-admin-page-when-updater.nextcloud.com-is-down
branch
from
23eda68 to
053157b
Compare
blizzz
deleted the
bugfix/noid/dont-block-admin-page-when-updater.nextcloud.com-is-down
branch
This was referenced Dec 7, 2023
|
/backport to stable28 |
|
This was merged before branch off |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
….com
Fix #40088
Summary
On the weekend our server was down multiple times. This made the admin settings overview non accessible as there is a sync request to the update checker. I can't find the time to make this async via JS, but I can send a PR so we only wait 5 seconds instead of until the request times out.
Checklist