Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore NoUserException for shares from ghosts #3953

Merged
merged 4 commits into from
Mar 23, 2017
Merged

Ignore NoUserException for shares from ghosts #3953

merged 4 commits into from
Mar 23, 2017

Conversation

MorrisJobke
Copy link
Member

cc @rullzer @icewind1991

@MorrisJobke
Ignore NoUserException for shares from ghosts
a4ce440 
Add unit tests for FailedStorage init from SharedStorage

Signed-off-by: Morris Jobke <[email protected]>
@MorrisJobke MorrisJobke added 3. to review Waiting for reviews downstream labels Mar 20, 2017
@MorrisJobke MorrisJobke added this to the Nextcloud 12.0 milestone Mar 20, 2017
rullzer
rullzer approved these changes Mar 20, 2017
View reviewed changes
Copy link
Member

@rullzer rullzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense

ChristophWurst
ChristophWurst approved these changes Mar 20, 2017
View reviewed changes
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@ChristophWurst ChristophWurst added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Mar 20, 2017
@MorrisJobke MorrisJobke added 2. developing Work in progress and removed 4. to release Ready to be released and/or waiting for tests to finish labels Mar 20, 2017
@MorrisJobke
Copy link
Member Author

Okay the unit tests fail ... Anybody interested in looking into it?

@MorrisJobke
Copy link
Member Author 

1) OCA\Files_Sharing\Tests\SharedStorageTest::testInitWithNonExistingUser
Undefined index: path
lib/private/Files/Cache/CacheEntry.php:70
apps/files_sharing/lib/Cache.php:63
apps/files_sharing/lib/SharedStorage.php:360
apps/files_sharing/tests/SharedStorageTest.php:580

2) OCA\Files_Sharing\Tests\SharedStorageTest::testInitWithNotFoundSource
Undefined index: path
lib/private/Files/Cache/CacheEntry.php:70
apps/files_sharing/lib/Cache.php:63
apps/files_sharing/lib/SharedStorage.php:360
apps/files_sharing/tests/SharedStorageTest.php:597

@MorrisJobke
Copy link
Member Author

@icewind1991 Could you look into the error? Thanks

@MorrisJobke
Copy link
Member Author

👍

@MorrisJobke MorrisJobke merged commit a5a29ee into master Mar 23, 2017
@MorrisJobke MorrisJobke deleted the downstream-27027 branch March 23, 2017 21:26
@nickvergessen
Copy link
Member

Should backport the relevant changes to 11:
#3110

@nickvergessen nickvergessen added backport-request and removed 2. developing Work in progress labels May 12, 2017
@LukasReschke LukasReschke mentioned this pull request May 22, 2017
Merged
@LukasReschke
Copy link
Member

LukasReschke commented May 22, 2017 •
edited
Loading

Backport at #5052

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rullzer rullzer rullzer approved these changes

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

@LukasReschke LukasReschke Awaiting requested review from LukasReschke

@icewind1991 icewind1991 Awaiting requested review from icewind1991

Assignees

@icewind1991 icewind1991

Labels
None yet
Projects
None yet
Milestone
Nextcloud 12.0
Development

Successfully merging this pull request may close these issues.
6 participants
@MorrisJobke @nickvergessen @LukasReschke @rullzer @ChristophWurst @icewind1991